Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EditSingleEntityComponent without selected Entity looks very bad in default Form #1142

Closed
3 of 4 tasks
TheSlimvReal opened this issue Mar 16, 2022 · 2 comments
Closed
3 of 4 tasks

EditSingleEntityComponent without selected Entity looks very bad in default Form #1142

TheSlimvReal opened this issue Mar 16, 2022 · 2 comments
Labels
Status: Community Help Wanted (good first issue) simple tasks that don't require understanding every last detail of our platform Type: Bug Type: UX concerning user interface and in a broader sense user experience

Comments

@TheSlimvReal
Copy link
Collaborator

TheSlimvReal commented Mar 16, 2022 •
edited by sleidig
Loading

Describe the bug
When having a field as DisplaySingleEntity in the default forms and no entity is selected yet, the form element looks very bad.

image

What should be done is

  • Form element should looks similar to neighboring elements when nothing is selected
  • Name of attribute should be visible if nothing is selected
  • Element should be correctly marked as disabled

When a entity is selected, the form incorrectly shows an edit button when editing is disabled.

image

This should also not be visible and usable.

  • The edit button should only be shown when edit is clicked in the form component
@TheSlimvReal TheSlimvReal added Type: Bug Type: UX concerning user interface and in a broader sense user experience Status: Community Help Wanted (good first issue) simple tasks that don't require understanding every last detail of our platform labels Mar 16, 2022
@TheSlimvReal TheSlimvReal changed the title DisplayEntityComponent without selected Entity looks very bad in default Form EditSingleEntityComponent without selected Entity looks very bad in default Form Mar 16, 2022
@TheSlimvReal TheSlimvReal mentioned this issue Mar 16, 2022
Merged
1 task
@sleidig sleidig moved this to Triage in All Tasks & Issues Mar 21, 2022
@sleidig sleidig moved this from Triage to Todo in All Tasks & Issues Mar 21, 2022
Repository owner moved this from Todo to Done in All Tasks & Issues Mar 23, 2022
Repository owner moved this from Todo to Done in Important Fixes & Enhancements Mar 23, 2022
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.1.1-master.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Community Help Wanted (good first issue) simple tasks that don't require understanding every last detail of our platform Type: Bug Type: UX concerning user interface and in a broader sense user experience
Projects
All Tasks & Issues
Archived in project
Important Fixes & Enhancements
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheSlimvReal @aam-digital-ci