fix: edit single entity correctly works in forms #1144
Merged
+53
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://test-deployment-pr-1144.herokuapp.com/ |
# Conflicts: # src/app/core/entity-components/entity-form/entity-form/entity-form.stories.ts
sleidig
reviewed
Mar 22, 2022
| constructor(private dynamicEntityService: DynamicEntityService) { | ||
| constructor( | ||
| private dynamicEntityService: DynamicEntityService, | ||
| private changeDetection: ChangeDetectorRef |
There was a problem hiding this comment.
do we really, really need to handle change detection manually here?
There was a problem hiding this comment.
Unfortunately the asynchronous function makes this necessary
# Conflicts: # src/app/core/entity-components/entity-utils/dynamic-form-components/edit-single-entity/edit-single-entity.component.spec.ts # src/app/core/entity-components/entity-utils/dynamic-form-components/edit-single-entity/edit-single-entity.component.ts
sleidig
approved these changes
Mar 23, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 3.1.1-master.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
TheSlimvReal
added a commit
that referenced
this pull request
Mar 25, 2022
* refactor: Upgrade @sentry/browser from 6.17.6 to 6.18.1 (#1133) * fix: Changes in progress dashboard are correctly saved * fix: Recording attendance with an invalid date is no longer possible * test(storybook): simplify story setup with a utils StorybookBaseModule and fix most stories (#1145) * refactor: replacing component maps with dynamic registry * fix: improve performance of download button (#1151) * fix: sorting tables ignores case * fix: edit single entity correctly works in forms (#1144) * fix: menu highlighting when no "/" route is set (#1155) * fix: other sections are disabled when creating a new entity * feat: Improved data import feature * fix: release messages are correctly shown * refactor: bump minimist from 1.2.5 to 1.2.6 (#1158) * feat: Added support for multi selection * fix: exports support count queries * chore(i18n): updated german translation Co-authored-by: Snyk bot <snyk-bot@snyk.io> Co-authored-by: Schottkyc137 <45085299+Schottkyc137@users.noreply.github.com> Co-authored-by: Sebastian <sebastian.leidig@gmail.com> Co-authored-by: Alexander S <57322198+Osbie-Feel@users.noreply.github.com> Co-authored-by: Spikeone <fvv1@gmx.de> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue: #1142
Visible/Frontend Changes
Architectural/Backend Changes
--