Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: menu highlighting when no "/" route is set #1155

Merged
merged 3 commits into from
Mar 24, 2022
Merged

Conversation

TheSlimvReal
Copy link
Collaborator

see issue: #1143

Visible/Frontend Changes

  • menu highlighting always works

Architectural/Backend Changes

--

Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sleidig sleidig merged commit c3d9491 into master Mar 24, 2022
@sleidig sleidig deleted the fix_menu_highlighting branch March 24, 2022 08:39
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.1.1-master.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

TheSlimvReal added a commit that referenced this pull request Mar 25, 2022
* refactor: Upgrade @sentry/browser from 6.17.6 to 6.18.1 (#1133)

* fix: Changes in progress dashboard are correctly saved

* fix: Recording attendance with an invalid date is no longer possible

* test(storybook): simplify story setup with a utils StorybookBaseModule and fix most stories (#1145)

* refactor: replacing component maps with dynamic registry

* fix: improve performance of download button (#1151)

* fix: sorting tables ignores case

* fix: edit single entity correctly works in forms (#1144)

* fix: menu highlighting when no "/" route is set (#1155)

* fix: other sections are disabled when creating a new entity

* feat: Improved data import feature

* fix: release messages are correctly shown

* refactor: bump minimist from 1.2.5 to 1.2.6 (#1158)

* feat: Added support for multi selection

* fix: exports support count queries

* chore(i18n): updated german translation

Co-authored-by: Snyk bot <snyk-bot@snyk.io>
Co-authored-by: Schottkyc137 <45085299+Schottkyc137@users.noreply.github.com>
Co-authored-by: Sebastian <sebastian.leidig@gmail.com>
Co-authored-by: Alexander S <57322198+Osbie-Feel@users.noreply.github.com>
Co-authored-by: Spikeone <fvv1@gmx.de>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants