Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancelling to create a new note still adds it, no matter whether you say yes or no in confirmation #1258

Closed
sleidig opened this issue May 6, 2022 · 1 comment
Closed

Cancelling to create a new note still adds it, no matter whether you say yes or no in confirmation #1258

sleidig opened this issue May 6, 2022 · 1 comment
Labels
Type: Bug

Comments

@sleidig
Copy link
Member

sleidig commented May 6, 2022

To Reproduce
Steps to reproduce the behavior:

  1. Go to notes list
  2. Click on 'add new'
  3. Give the note some title but then click "Cancel"

Bug A:
4. The app asks you whether you want to discard changes, say "Yes"
5. --> A new empty note is still added to the notes list nevertheless (would expect no new note to be saved)
Bug B:
4. repeat 1.-3. and then say "No" to discarding changes
5. --> A new empty note is added (but the title you gave it seems to be discarded)
@TheSlimvReal
Copy link
Collaborator

The app asks you whether you want to save the changes.

Bug A: Cannot reproduce
Bug B: Will be fixed with #1261

@sleidig sleidig mentioned this issue May 12, 2022
Merged
TheSlimvReal added a commit that referenced this issue May 12, 2022
@sleidig @TheSlimvReal
feat(attendance): allow reviewing/editing of an event after roll call (…
5bb93f8 
…#1261)

fixes: #953 #1258

Co-authored-by: Simon <therealslimv@yahoo.de>
Co-authored-by: Simon <33730997+TheSlimvReal@users.noreply.github.com>
Repository owner moved this from Priority to Done in Important Fixes & Enhancements May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug
Projects
No open projects
Important Fixes & Enhancements
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sleidig @TheSlimvReal