Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(attendance): allow reviewing/editing of an event after roll call #1261

Merged
merged 6 commits into from
May 12, 2022

Conversation

sleidig
Copy link
Member

@sleidig sleidig commented May 10, 2022

also see #953

@github-actions
Copy link

@sleidig
Copy link
Member Author

sleidig commented May 10, 2022

there still is a problem that changing a participant's status in the note-details popup and then going into the roll call again, the roll call still shows the old status (as a copy is created for the popup to allow cancelling). @TheSlimvReal , any idea for an easy fix for that?

@TheSlimvReal
Copy link
Collaborator

@sleidig
I have made the following changes to have the expected behavior:

  • Clicking Review details does not automatically navigate back to the roll-call setup, otherwise the event notes are fetched from the database before the changes from the popup are saved
  • Removed copy of entity in RollCallComponent and added correct deep copy inside DialogWrapperComponent to have correct cancel behavior
  • Restructured RollCallComponent to not cache the attendance statuses but instead always take them from the (Event-)Note

@sleidig
Copy link
Member Author

sleidig commented May 12, 2022

Thanks a lot, @TheSlimvReal ! Reviewed and tested your additions and confirming the fix for #1258 . From my side this is good to go 💯

@sleidig sleidig requested a review from TheSlimvReal May 12, 2022 08:37
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TheSlimvReal TheSlimvReal merged commit 5bb93f8 into master May 12, 2022
@TheSlimvReal TheSlimvReal deleted the event-details-link branch May 12, 2022 09:42
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.6.0-master.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants