Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change detection is correctly triggered to build new filters #1584

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

TheSlimvReal
Copy link
Collaborator

see issue: #1570
As the additional events were only pushed to the existing array, no new change detection was triggered. Instead, we now correctly create a new array once all the additional events were created.

Visible/Frontend Changes

  • Filters in roll call setup show all available options

Architectural/Backend Changes

--

@TheSlimvReal TheSlimvReal requested a review from sleidig December 12, 2022 17:03
@github-actions
Copy link

Deployed to https://pr-1584.aam-digital.net/

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

This is not related to #1478, is it?

@sleidig sleidig merged commit 8849ad7 into master Dec 13, 2022
@sleidig sleidig deleted the filter_fixes branch December 13, 2022 08:36
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.15.1-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.15.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.15.2-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.15.1-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

2 similar comments
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants