Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix entitysubrecord #1590

Merged
merged 7 commits into from
Dec 15, 2022
Merged

Fix entitysubrecord #1590

merged 7 commits into from
Dec 15, 2022

Conversation

sleidig
Copy link
Member

@sleidig sleidig commented Dec 13, 2022

see commits

@github-actions
Copy link

Deployed to https://pr-1590.aam-digital.net/

@sleidig
Copy link
Member Author

sleidig commented Dec 13, 2022

Wait ... this actually breaks the columnsToDisplay. I wanted to be able to display a column added later programmatically - but now the EntityList tabs are messed up

@sleidig sleidig force-pushed the fix-entitysubrecord branch from aa601d8 to 83ab644 Compare December 14, 2022 11:06
@sleidig sleidig force-pushed the fix-entitysubrecord branch from 83ab644 to 52eff0b Compare December 14, 2022 11:07
@sleidig sleidig requested a review from TheSlimvReal December 14, 2022 11:07
@TheSlimvReal
Merge remote-tracking branch 'origin/fix-entitysubrecord' into fix-en…
29bfa30 
…titysubrecord

# Conflicts:
#	src/app/core/entity-components/entity-subrecord/entity-subrecord/entity-subrecord.component.ts
@TheSlimvReal
fixed tests
05fcce9
@TheSlimvReal
fixed tests
00cd5fb
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TheSlimvReal TheSlimvReal merged commit 4f22246 into master Dec 15, 2022
@TheSlimvReal TheSlimvReal deleted the fix-entitysubrecord branch December 15, 2022 14:09
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.15.1-master.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

TheSlimvReal added a commit that referenced this pull request Dec 16, 2022
@sleidig @TheSlimvReal
fix: entity, which doesn't pass filter is only removed from table aft…
6b16446 
…er short delay (#1590)

Co-authored-by: Simon <simon@aam-digital.com>
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.15.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.15.2-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.15.1-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

2 similar comments
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSlimvReal TheSlimvReal TheSlimvReal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sleidig @aam-digital-ci @TheSlimvReal