-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(import): array properties can be imported #1665
Conversation
Deployed to https://pr-1665.aam-digital.net/ |
@@ -134,11 +140,29 @@ export class DataImportService { | |||
return Entity.createPrefixedId(importMeta.entityType, value); | |||
} else if (importMeta.dateFormat && this.dateDataTypes.includes(dataType)) { | |||
return this.transform2Date(value, importMeta.dateFormat); | |||
} else if (this.arrayDataTyps.includes(dataType)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to stack this recursively in a way so that array items might also be parsed with transform2Date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally yes. I would however postpone this to when there is actually a use-case for this. At the moment our app is not supporting arrays of dates anyways and there are no other data types that are transformed during import.
Kudos, SonarCloud Quality Gate passed!
|
🎉 This PR is included in version 3.17.0-master.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.17.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Array properties can be imported with CSV. Have a look at the tests to see the supported formats
see #1610