Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(import): array properties can be imported #1665

Merged
merged 5 commits into from
Jan 24, 2023
Merged

Conversation

TheSlimvReal
Copy link
Collaborator

@TheSlimvReal TheSlimvReal commented Jan 17, 2023

Array properties can be imported with CSV. Have a look at the tests to see the supported formats

see #1610

@github-actions
Copy link
Contributor

Deployed to https://pr-1665.aam-digital.net/

@@ -134,11 +140,29 @@ export class DataImportService {
return Entity.createPrefixedId(importMeta.entityType, value);
} else if (importMeta.dateFormat && this.dateDataTypes.includes(dataType)) {
return this.transform2Date(value, importMeta.dateFormat);
} else if (this.arrayDataTyps.includes(dataType)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to stack this recursively in a way so that array items might also be parsed with transform2Date?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally yes. I would however postpone this to when there is actually a use-case for this. At the moment our app is not supporting arrays of dates anyways and there are no other data types that are transformed during import.

@sleidig sleidig mentioned this pull request Jan 24, 2023
1 task
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TheSlimvReal TheSlimvReal merged commit 4298c33 into master Jan 24, 2023
@TheSlimvReal TheSlimvReal deleted the import_array branch January 24, 2023 15:28
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.17.0-master.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants