Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic entities #1670

Merged
merged 12 commits into from
Jan 24, 2023
Merged

Dynamic entities #1670

merged 12 commits into from
Jan 24, 2023

Conversation

TheSlimvReal
Copy link
Collaborator

see issue: #1056

Visible/Frontend Changes

  • [x]
  • [ ]

Architectural/Backend Changes

  • New entities can be defined in config

@github-actions
Copy link
Contributor

Deployed to https://pr-1670.aam-digital.net/

@sleidig
Copy link
Member

sleidig commented Jan 23, 2023

reports do not support the custom entities yet?

Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and seems to work for the client in its deployment 👍

Related and still to do: Reports do not support all these entity types yet (and we need them there as well).

import { entityArrayEntitySchemaDatatype } from "../../entity/schema-datatypes/datatype-entity-array";
import { EntityConstructor } from "../../entity/model/entity";

export function isArrayProperty(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also use this for the importservice (PR #1665 )

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TheSlimvReal TheSlimvReal merged commit db457c4 into master Jan 24, 2023
@TheSlimvReal TheSlimvReal deleted the dynamic_entities branch January 24, 2023 15:00
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.17.0-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants