fix: created custom form input for boolean values #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://pr-1715.aam-digital.net/ |
sleidig
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
Looks and works good 👍
I actually like how this has a similar mat-form-field boxing!
I would tend towards making the checkbox label font-size same as the actual values of other fields. While logically "inactive" is a label not a value here, from the look and feel it appears a bit off to me:
what do you think?
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 3.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once again see issue: #1683
It seemed like the issue occurred, because
EditBooleanComponentwas not yet using amat-form-field.Using the new
CustomFormControlDirectiveI created aBooleanInputcomponent that can be used inside amat-form-field.Some stylings needed to be adjusted.
Visible/Frontend Changes
Architectural/Backend Changes
--