Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing queries don't throw errors #1744

Merged
merged 3 commits into from
Mar 2, 2023
Merged

fix: missing queries don't throw errors #1744

merged 3 commits into from
Mar 2, 2023

Conversation

TheSlimvReal
Copy link
Collaborator

It's possible to make a row without actually defining a query on it (e.g. to group further queries) this however currently throws error.

Visible/Frontend Changes

  • [x]
  • [ ]

Architectural/Backend Changes

  • [x]
  • [ ]

@github-actions
Copy link

Deployed to https://pr-1744.aam-digital.net/

src/app/core/export/query.service.spec.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TheSlimvReal TheSlimvReal merged commit d7c5159 into master Mar 2, 2023
@TheSlimvReal TheSlimvReal deleted the query_fix branch March 2, 2023 10:23
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants