Add option safari (and firefox?) #1750
Conversation
|
Deployed to https://pr-1750.aam-digital.net/ |
| @@ -142,6 +143,7 @@ export class BasicAutocompleteComponent<O, V = O> | |||
| let filteredOptions = this._options; | |||
| this.showAddOption = false; | |||
| clearTimeout(this.addOptionTimeout); | |||
| setTimeout(() => (this.showAddOption = false), 100); | |||
There was a problem hiding this comment.
observing actual users add options, I am tending towards removing the delay for new options again. It was complex enough for a non-savvy user to figure out they can do this without things moving and changing. Maybe instead highlight the "Add new" option with different color a bit more than already?
Sorry, somewhat off-topic here actually. Just popped into my mind.
There was a problem hiding this comment.
Got point. I removed the timeout and instead visually highlighted the add option text. Please have a look
There was a problem hiding this comment.
Nice. I like it.
In terms of UI logic, maybe we should use the blue accent color though (similar to add buttons above lists, etc.)?
There was a problem hiding this comment.
I get the point but it does not look good with the blue color.
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 3.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Visible/Frontend Changes
Architectural/Backend Changes
--