Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved support of active schools #1754

Merged
merged 18 commits into from
Mar 14, 2023
Merged

Improved support of active schools #1754

merged 18 commits into from
Mar 14, 2023

Conversation

TheSlimvReal
Copy link
Collaborator

@TheSlimvReal TheSlimvReal commented Mar 6, 2023

see issue: #694
This approach builds a complex view where children/schools and their connected relations can be loaded with a single request. This improves the query performance significantly as the current solution was making a request for each child.

Also I added support for multiple active schools in children list.

Visible/Frontend Changes

  • All schools and school classes are visible instantly on children list
  • All active schools can be shown in children list (MIGRATION REQUIRED)
  • School filter works for multiple active schools of a child in children list
  • (?) All active schools are schon in ChildBlockComponent
  • (?) All classes of the active schools are shown

Architectural/Backend Changes

  • Single index for child - school link that loads all required data in one request

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Deployed to https://pr-1754.aam-digital.net/

Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely seems much cleaner and clearer with the promises and other changes 👍

This pops up in my console (not sure whether/how it is related):
image

Functional seems to work well in in-memory as well as local mode.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TheSlimvReal TheSlimvReal merged commit 9ee705e into master Mar 14, 2023
@TheSlimvReal TheSlimvReal deleted the children_school_index branch March 14, 2023 18:32
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants