Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click on Entity in disabled form should open details page #1762

Closed
TheSlimvReal opened this issue Mar 10, 2023 · 3 comments · Fixed by #2220
Closed

Click on Entity in disabled form should open details page #1762

TheSlimvReal opened this issue Mar 10, 2023 · 3 comments · Fixed by #2220
Assignees
@brajesh-lab
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Status: Community Help Wanted (good first issue) simple tasks that don't require understanding every last detail of our platform Type: Improvement Improvement/Extension of existing feature with benefit for the user

Comments

@TheSlimvReal
Copy link
Collaborator

TheSlimvReal commented Mar 10, 2023 •
edited by sleidig
Loading

When having a reference to an entity in a form and the form is disabled, then the name of the referenced entity should be clickable to navigate to the details page of the linked entity.

image

  • implement for both EditSingleEntityComponent and EditEntityArrayComponent
    • Entity.route provides the route to navigate to for the given entity type
  • make the UI of the two components more similar, so that both display an entity reference as a block with background or border.
@TheSlimvReal TheSlimvReal added Type: Improvement Improvement/Extension of existing feature with benefit for the user Status: Community Help Wanted (good first issue) simple tasks that don't require understanding every last detail of our platform labels Mar 10, 2023
@TheSlimvReal TheSlimvReal mentioned this issue Mar 10, 2023
Merged
@sleidig sleidig moved this from Triage to Todo [community help wanted] in All Tasks & Issues Apr 24, 2023
@sleidig
Copy link
Member

sleidig commented Sep 19, 2023

Related to this: For better UX the EditSingleEntity should, in my opinion, have the same style as the multi-select, EditEntityArray (i.e. both showing the rounded block to indicate this is more than just free text).

@sleidig sleidig added the CC label Sep 22, 2023
@brajesh-lab brajesh-lab self-assigned this Oct 9, 2023
@brajesh-lab brajesh-lab moved this from Todo [help wanted] to In Progress in All Tasks & Issues Oct 9, 2023
@brajesh-lab brajesh-lab moved this from In Progress to Todo [help wanted] in All Tasks & Issues Nov 2, 2023
brajesh-lab pushed a commit that referenced this issue Nov 4, 2023
#1762 chahed UI for singleEntities and entityArray
8dd75f9
@brajesh-lab brajesh-lab mentioned this issue Nov 4, 2023
Closed
1 task
@brajesh-lab brajesh-lab moved this from Todo [help wanted] to In Progress in All Tasks & Issues Nov 5, 2023
@sleidig sleidig moved this from In Progress to In Review in All Tasks & Issues Nov 9, 2023
@sleidig sleidig mentioned this issue Jan 12, 2024
Closed
5 tasks
@sleidig sleidig moved this from In Review to Todo [help wanted] in All Tasks & Issues Jan 22, 2024
@sleidig sleidig removed the CC label Jan 26, 2024
sleidig added a commit that referenced this issue Feb 6, 2024
@sleidig
fix: navigate to details upon click in "entity-select" form field
bde7a38 
closes #1762
@sleidig sleidig mentioned this issue Feb 6, 2024
Merged
sleidig added a commit that referenced this issue Feb 6, 2024
@sleidig
fix: navigate to details upon click in "entity-select" form field
e65c04d 
closes #1762
@github-project-automation github-project-automation bot moved this from Todo [help wanted] to Done in All Tasks & Issues Feb 6, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.31.2-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Feb 6, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.32.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brajesh-lab brajesh-lab

Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Status: Community Help Wanted (good first issue) simple tasks that don't require understanding every last detail of our platform Type: Improvement Improvement/Extension of existing feature with benefit for the user
Projects
All Tasks & Issues
Archived in project
Milestone
No milestone
4 participants
@sleidig @TheSlimvReal @aam-digital-ci @brajesh-lab