Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync restart on errors #1767

Merged
merged 5 commits into from
Mar 15, 2023
Merged

Sync restart on errors #1767

merged 5 commits into from
Mar 15, 2023

Conversation

TheSlimvReal
Copy link
Collaborator

@TheSlimvReal TheSlimvReal commented Mar 14, 2023

Trying to solve the Failed to execute 'transaction' on 'IDBDatabase': The database connection is closing. which sometimes causes the sync to stop and some data not being synchronised. At the moment this can only be solved by calling the /db/admin/clear_local/app endpoint (which triggers a check of all revs at source and target).

Visible/Frontend Changes

  • [x]
  • [ ]

Architectural/Backend Changes

  • Sync restarts after complete or error callbacks are called
  • complete events are logged

@github-actions
Copy link
Contributor

Deployed to https://pr-1767.aam-digital.net/

@TheSlimvReal TheSlimvReal changed the title Sync testing Sync restart on errors Mar 14, 2023
@TheSlimvReal TheSlimvReal marked this pull request as ready for review March 14, 2023 18:29
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks okay, functionality seems hard to test (even going offline doesn't seem to trigger any of these sync events for me) but the general functionality seems to continue working :-)

@TheSlimvReal TheSlimvReal merged commit ffcdf1c into master Mar 15, 2023
@TheSlimvReal TheSlimvReal deleted the sync-testing branch March 15, 2023 13:48
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants