Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support avg queries #2026

Merged
merged 6 commits into from
Nov 14, 2023
Merged

fix: support avg queries #2026

merged 6 commits into from
Nov 14, 2023

Conversation

TheSlimvReal
Copy link
Collaborator

@TheSlimvReal TheSlimvReal commented Oct 13, 2023

Actually, I am not sure if something like sum of all actual divided by sum of all totals is more required. Will check.

@github-actions
Copy link

Deployed to https://pr-2026.aam-digital.net/

@TheSlimvReal TheSlimvReal marked this pull request as draft October 13, 2023 14:41
@sleidig sleidig self-requested a review November 13, 2023 10:53
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :-)

src/app/core/export/query.service.spec.ts Show resolved Hide resolved
src/app/core/export/query.service.ts Show resolved Hide resolved
@TheSlimvReal TheSlimvReal marked this pull request as ready for review November 14, 2023 09:02
@TheSlimvReal TheSlimvReal merged commit 731da68 into master Nov 14, 2023
8 checks passed
@TheSlimvReal TheSlimvReal deleted the material_per_school_report branch November 14, 2023 16:40
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.26.0-master.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Nov 14, 2023
sleidig added a commit that referenced this pull request Nov 15, 2023
Co-authored-by: Sebastian <sebastian@aam-digital.com>
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.26.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants