Duplicate a record #2042
Merged
Duplicate a record #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 18, 2023 12:34
sleidig
reviewed
Oct 26, 2023
sleidig
reviewed
Oct 31, 2023
src/app/core/duplicate-records/duplicate-records.service.spec.ts
Outdated
Show resolved
Hide resolved
|
@sleidig, This is ready for your review. Please take a look and suggest if changes are needed. |
sleidig
requested changes
Nov 2, 2023
src/app/core/common-components/entity-subrecord/entity-subrecord/entity-subrecord.component.ts
Outdated
Show resolved
Hide resolved
src/app/core/duplicate-records/duplicates-data-directive/duplicate-records.directive.ts
Outdated
Show resolved
Hide resolved
src/app/core/duplicate-records/duplicate-records.service.spec.ts
Outdated
Show resolved
Hide resolved
added 2 commits
November 3, 2023 17:00
sleidig
reviewed
Nov 3, 2023
src/app/core/entity-list/entity-list/entity-list.component.html
Outdated
Show resolved
Hide resolved
sleidig
reviewed
Nov 3, 2023
src/app/core/common-components/entity-subrecord/entity-subrecord/entity-subrecord.component.ts
Outdated
Show resolved
Hide resolved
sleidig
reviewed
Nov 6, 2023
sleidig
reviewed
Nov 6, 2023
src/app/core/common-components/entity-subrecord/entity-subrecord/entity-subrecord.component.ts
Outdated
Show resolved
Hide resolved
…rd/entity-subrecord.component.ts
closes #1361 Co-authored-by: Sebastian Leidig <sebastian@aam-digital.com>
sleidig
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
I found and fixed one more functional problem:
If you select some rows and then switch the "tab" (i.e. the section above the table, which changes the columns that the table displays), then the selection in the UI did not keep the checkboxes selected (although internally it remembers the state).
I think this is good to go now 👍
|
🎉 This PR is included in version 3.26.0-master.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
sleidig
added a commit
that referenced
this pull request
Nov 7, 2023
closes #1362 Co-authored-by: Sebastian <sebastian@aam-digital.com>
sleidig
added a commit
that referenced
this pull request
Nov 8, 2023
closes #1362 Co-authored-by: Sebastian <sebastian@aam-digital.com>
|
🎉 This PR is included in version 3.26.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1362