Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guards fix #2129

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Guards fix #2129

merged 4 commits into from
Dec 18, 2023

Conversation

TheSlimvReal
Copy link
Collaborator

closes: #2128

  • EntityPermissionGuard waits for some rules to be initialised
  • AuthGuards needs to always be added before using another guard

@TheSlimvReal TheSlimvReal requested a review from sleidig December 14, 2023 09:38
Copy link

Deployed to https://pr-2129.aam-digital.net/

Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after reload the menu item is not highlighted anymore (maybe that also needs to be async until items are available?)

@TheSlimvReal TheSlimvReal requested a review from sleidig December 16, 2023 10:59
@sleidig sleidig merged commit b449802 into master Dec 18, 2023
7 checks passed
@sleidig sleidig deleted the guards_fix branch December 18, 2023 11:01
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.28.0-master.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Dec 18, 2023
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.28.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reloading page redirects to 404
3 participants