Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reloading page redirects to 404 #2128

Closed
sleidig opened this issue Dec 13, 2023 · 2 comments · Fixed by #2129
Closed

Reloading page redirects to 404 #2128

sleidig opened this issue Dec 13, 2023 · 2 comments · Fixed by #2129
Assignees
@TheSlimvReal
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Type: Bug

Comments

@sleidig
Copy link
Member

sleidig commented Dec 13, 2023

Probably since PR #2125 the system sends users to 404 page when reloading on a route that has permissions (e.g. /school or /child). While we have changed the system to avoid giving access to any route (including ones without permission), for routes with permission the user should be able to reload.
@TheSlimvReal TheSlimvReal self-assigned this Dec 14, 2023
@TheSlimvReal TheSlimvReal mentioned this issue Dec 14, 2023
Merged
2 tasks
@sleidig sleidig moved this from Triage to In Review in All Tasks & Issues Dec 15, 2023
sleidig pushed a commit that referenced this issue Dec 18, 2023
@TheSlimvReal
fix: entity permission guards waits for rules to be available (#2129)
b449802 
closes #2128
@github-project-automation github-project-automation bot moved this from In Review to Done in All Tasks & Issues Dec 18, 2023
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.28.0-master.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Dec 18, 2023
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.28.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheSlimvReal TheSlimvReal

Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Type: Bug
Projects
All Tasks & Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Guards fix Aam-Digital/ndb-core
3 participants
@sleidig @TheSlimvReal @aam-digital-ci