-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new EntityPermissionGuard to check for EntityAbility #2125
Conversation
sleidig
commented
Dec 11, 2023
•
edited
Loading
edited
- PROBLEM: on new load (i.e. when typing the special URL in the browser), the EntityAbility does not seem to have the permissions loaded yet and is allowing any access.
- make this apply on all routes by default
- make Navigation menu check also for this guard, not only for userRoleGuard when hiding menu items
Deployed to https://pr-2125.aam-digital.net/ |
src/app/core/permissions/permission-guard/entity-permission.guard.ts
Outdated
Show resolved
Hide resolved
To test critical path: (1) create a route with EntityPermissionGuard, e.g. in app.routing.ts:
(2) change DatatabaseRules in demo-permission-generator.service.ts for user_app, to have some missing entity permissions (3) visit that path, and also reload page on the forbidden path as this has previously been an error |
… actual permissions are loaded
🎉 This PR is included in version 3.28.0-master.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.28.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |