Other entity login #2143

TheSlimvReal · 2023-12-22T08:56:23Z

closes: #2132 #1685 #1513

UserSecurityComponent is entity agnostic
generalize $currentUser default value -> assign full entity ID and support "foreign" entity types in display/edit entity components -> This comes with the limitation that our default filter (e.g. notes of child) will not include this "foreign" references (e.g. when a child has been added as author of a note)
generalize Todo completed by
generalize Todo and roll call filter for current user by still looking in same property but check with full and short ID match to also support "foreign" entities (maybe we just do Refactor getId() function #1526 and skip this)
fix list paginator to also work with other logged in entitites -> store in local storage for now
Make username (exact_username attribute in keycloak) access token claim optional and use user ID instead for local DB names
Use human readable name (not exact_username) claim for offline user selection
Adjust Keycloak email message -> fix: Improved Keycloak email content ndb-setup#28

github-actions · 2023-12-22T08:56:41Z

Deployed to https://pr-2143.aam-digital.net/

src/app/features/todos/todo.service.ts

src/app/core/common-components/entity-subrecord/list-paginator/list-paginator.component.ts

sleidig

Code looks nice 👍
I guess this required the getId() PR to be merged first?

Tested

pagination
todo completion

not tested

user security component with Keycloak BE
todo completion with non-user user entity

Profile (menu bottom) shows an error in demo mode: undefined (reading 'loadUserInfo')
demo mode SecurityComponent still queries keycloak (and fails) - should we prevent that?
complete todo shows error in details popup and related-todos list: Cannot read properties of undefined (reading 'toString')

...app/core/basic-datatypes/entity-array/display-entity-array/display-entity-array.component.ts

src/app/core/basic-datatypes/entity/display-entity/display-entity.component.ts

src/app/core/common-components/entity-select/entity-select.component.ts

src/app/core/common-components/entity-form/entity-form.service.ts

# Conflicts: # src/app/core/basic-datatypes/entity/display-entity/display-entity.component.ts # src/app/core/common-components/entity-form/entity-form.service.spec.ts # src/app/core/common-components/entity-select/entity-select.component.spec.ts # src/app/core/common-components/entity-select/entity-select.component.ts # src/app/core/entity/default-datatype/view.directive.ts # src/app/core/session/session-service/session-manager.service.ts # src/app/features/todos/todo-completion/display-todo-completion/display-todo-completion.component.html # src/app/features/todos/todo-completion/display-todo-completion/display-todo-completion.component.spec.ts # src/app/features/todos/todo-completion/display-todo-completion/display-todo-completion.component.ts

TheSlimvReal · 2024-02-06T13:20:39Z

@sleidig I did not change anything about the failing Keycloak requests in the demo mode yet. I am not sure what we actually want there. Someone added the account manager role to the demo admin user which enables the component. If we just remove this role, the errors disappear. Or do we want to showcase something there in the demo mode?

sleidig · 2024-02-06T13:29:21Z

@sleidig I did not change anything about the failing Keycloak requests in the demo mode yet. I am not sure what we actually want there. Someone added the account manager role to the demo admin user which enables the component. If we just remove this role, the errors disappear. Or do we want to showcase something there in the demo mode?

I thought we've linked the user list to that role, but apparently it is using admin_app. So what you are saying makes sense - can't think of a need for account_manager in demo mode.

sleidig

Further Testing:

user profile (bottom left):
- the username field gets overwritten by my Lastpass - although I guess it is disabled? (maybe something for another day ...)
- can we add a link to the Entity the "User profile" (i.e. entity) this is represented as in our system? (maybe simply with display-entity? / edit-entity)
creating new user accounts:
- the email template says "Your email has been linked to the Aam Digital user: User:Aadi". This will for most cases now be very cryptic - and otherwise might confuse people about what to put into the login form. Shall we take out that sentence and just say "An account for the Aam Digital system has been created for your email. By confirming your account below, you can set a password and then log in using this email as your username."?
- new user is linked and using correct entity to prefill notes
- config the UserSecurity component for child details and creating user account from there works
tasks & notes (with pre-filled current user's entity)
- works for notes + tasks with User and Child entity, as expected
- works without errors if no entity for the user account
- task completion works with any entity type

sleidig · 2024-02-06T13:37:27Z

src/app/core/common-components/entity-select/entity-select.component.ts

+      : await this.entityMapperService.load<E>(type, id);
+
+    if (!entity) {
+      throw Error(`Entity not found`);


Suggested change

throw Error(`Entity not found`);

throw Error(`Entity ${id} not found`);

I have added the ID logging to the surrounding function.

src/app/core/session/auth/keycloak/keycloak-auth.service.ts

src/app/core/session/session-service/session-manager.service.spec.ts

TheSlimvReal · 2024-02-07T09:02:36Z

@sleidig For LastPass there are two options. I recommend checking "Don't overwrite fields that are already filled" ("Account" > "Extensions Settings" > "General" at the bottom), which will also disable this at other locations (e.g. Keycloak UI).
There is also the option to explicitly tell LastPass to ignore this field

…pec.ts Co-authored-by: Sebastian <sebastian@aam-digital.com>

TheSlimvReal · 2024-02-07T10:05:09Z

@sleidig Thanks for the review.
Please see my comment above regarding LastPass. I have also adjusted the Keycloak templates (Aam-Digital/ndb-setup#28). Please have a look at the UI or the linked entity and feel free to adjust this.

aam-digital-ci · 2024-02-08T09:41:19Z

🎉 This PR is included in version 3.32.0-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

aam-digital-ci · 2024-02-16T12:34:28Z

🎉 This PR is included in version 3.32.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

TheSlimvReal added 3 commits December 21, 2023 18:34

session manager can load other entities

097373e

removed deprecated todo?

7bf56b9

user security component is entity agnostic

64c48bc

mage todo completion entity agnostic

3d2daa8

TheSlimvReal commented Dec 22, 2023

View reviewed changes

src/app/features/todos/todo.service.ts Show resolved Hide resolved

TheSlimvReal added 8 commits December 22, 2023 10:55

added test

4df0a8f

entity select can handle foreign entity references

9cf9313

fix display entity array to show entities again

d50d44a

display entity array shows foreign entities

15ad1ab

display single entity allows foreign entities to be displayed

079ab70

improved error message in MockEntityMapper

a830f9c

added support for foreign entities in DisplayEntityComponent

79506e4

use local storage to save paginator settings

9e15830

TheSlimvReal commented Dec 22, 2023

View reviewed changes

src/app/core/common-components/entity-subrecord/list-paginator/list-paginator.component.ts Outdated Show resolved Hide resolved

sleidig requested changes Jan 3, 2024

View reviewed changes

This was referenced Jan 22, 2024

fix(core): new unique-id validator #2134

Merged

replace custom user-account component with the "normal" user view #1622

Closed

sleidig reviewed Feb 5, 2024

View reviewed changes

src/app/core/common-components/entity-form/entity-form.service.ts Outdated Show resolved Hide resolved

TheSlimvReal added 10 commits February 5, 2024 17:34

fixed tests

5f93ef1

removed further usages of short id

7282b5f

made user entity optional

a437de6

made username claim optional

dd03437

fixed issue with unassigned default values on array properties

cdfee7f

only loading missing entities of other types in entity select

4c6f3e4

using ID as username in keycloak

fb6b4b2

some code cleanup

fc112fc

Merge branch 'master' into other_entity_login

878d5a6

TheSlimvReal marked this pull request as ready for review February 6, 2024 13:18

TheSlimvReal requested a review from sleidig February 6, 2024 13:18

sleidig reviewed Feb 6, 2024

View reviewed changes

sleidig mentioned this pull request Feb 6, 2024

customer support account without a user entity #1685

Closed

TheSlimvReal linked an issue Feb 7, 2024 that may be closed by this pull request

customer support account without a user entity #1685

Closed

TheSlimvReal and others added 2 commits February 7, 2024 10:12

Update src/app/core/session/session-service/session-manager.service.s…

74f45cc

…pec.ts Co-authored-by: Sebastian <sebastian@aam-digital.com>

added interface for parsed JWT

2e261a7

TheSlimvReal force-pushed the other_entity_login branch from 046e94d to 411e2e3 Compare February 7, 2024 09:42

TheSlimvReal added 3 commits February 7, 2024 11:00

automatically adding User prefix to tokens with short entityId

8b663a4

showing linked user entity in user account page

d1ec5c0

removed account manager role from demo mode

211e229

TheSlimvReal force-pushed the other_entity_login branch from 411e2e3 to 211e229 Compare February 7, 2024 10:02

TheSlimvReal linked an issue Feb 7, 2024 that may be closed by this pull request

Directly editing account information after creation #1513

Closed

improve user profile ui

f97689a

sleidig approved these changes Feb 8, 2024

View reviewed changes

TheSlimvReal added 2 commits February 8, 2024 08:24

Merge branch 'master' into other_entity_login

91216b8

removed unused styles

2ca6de3

TheSlimvReal merged commit 081a23f into master Feb 8, 2024
6 of 7 checks passed

TheSlimvReal deleted the other_entity_login branch February 8, 2024 09:40

aam-digital-ci added the released on @master managed by CI (semantic-release) label Feb 8, 2024

aam-digital-ci added the released managed by CI (semantic-release) label Feb 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Other entity login #2143

Other entity login #2143

TheSlimvReal commented Dec 22, 2023 •

edited

Loading

github-actions bot commented Dec 22, 2023

sleidig left a comment •

edited by TheSlimvReal

Loading

TheSlimvReal commented Feb 6, 2024

sleidig commented Feb 6, 2024

sleidig left a comment •

edited

Loading

sleidig Feb 6, 2024

TheSlimvReal Feb 7, 2024

TheSlimvReal commented Feb 7, 2024 •

edited

Loading

TheSlimvReal commented Feb 7, 2024

aam-digital-ci commented Feb 8, 2024

aam-digital-ci commented Feb 16, 2024

	throw Error(`Entity not found`);
	throw Error(`Entity ${id} not found`);

Other entity login #2143

Other entity login #2143

Conversation

TheSlimvReal commented Dec 22, 2023 • edited Loading

github-actions bot commented Dec 22, 2023

sleidig left a comment • edited by TheSlimvReal Loading

Choose a reason for hiding this comment

TheSlimvReal commented Feb 6, 2024

sleidig commented Feb 6, 2024

sleidig left a comment • edited Loading

Choose a reason for hiding this comment

sleidig Feb 6, 2024

Choose a reason for hiding this comment

TheSlimvReal Feb 7, 2024

Choose a reason for hiding this comment

TheSlimvReal commented Feb 7, 2024 • edited Loading

TheSlimvReal commented Feb 7, 2024

aam-digital-ci commented Feb 8, 2024

aam-digital-ci commented Feb 16, 2024

TheSlimvReal commented Dec 22, 2023 •

edited

Loading

sleidig left a comment •

edited by TheSlimvReal

Loading

sleidig left a comment •

edited

Loading

TheSlimvReal commented Feb 7, 2024 •

edited

Loading