Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RelatedEntities component loads with error if some records are missing the field #2172

Closed
sleidig opened this issue Jan 10, 2024 · 3 comments · Fixed by #2174
Closed

RelatedEntities component loads with error if some records are missing the field #2172

sleidig opened this issue Jan 10, 2024 · 3 comments · Fixed by #2174
Assignees
@sleidig
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)

Comments

@sleidig
Copy link
Member

sleidig commented Jan 10, 2024

If a RelatedEntities table is displayed on the details screen and some of the records to be loaded there are missing the mapping "property" field, then that component loads indefinetely (throwing an error trying to read ".includes" on undefined)
@sleidig sleidig self-assigned this Jan 11, 2024
@sleidig sleidig moved this from Triage to In Progress in All Tasks & Issues Jan 11, 2024
sleidig added a commit that referenced this issue Jan 11, 2024
@sleidig
fix(core): related-entities can handle records where the mapped field…
3d70d13 
… is undefined

fixes #2172
@sleidig sleidig moved this from In Progress to In Review in All Tasks & Issues Jan 11, 2024
@sleidig sleidig mentioned this issue Jan 11, 2024
Merged
sleidig added a commit that referenced this issue Jan 12, 2024
@sleidig
fix(core): related-entities can handle records where the mapped field…
1e42d99 
… is undefined (#2174)

fixes #2172
@github-project-automation github-project-automation bot moved this from In Review to Done in All Tasks & Issues Jan 12, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.28.1-master.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Jan 12, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.29.0-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleidig sleidig

Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
All Tasks & Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core): related-entities can handle records where the mapped field… Aam-Digital/ndb-core
2 participants
@sleidig @aam-digital-ci