Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label not persist in data structure edit mode #2183

Closed
tomwwinter opened this issue Jan 17, 2024 · 2 comments
Closed

label not persist in data structure edit mode #2183

tomwwinter opened this issue Jan 17, 2024 · 2 comments
Assignees

Comments

@tomwwinter
Copy link
Contributor

tomwwinter commented Jan 17, 2024

Describe the bug
Manipulated entities in structure edit view does not persist correctly. The position is saved correctly, but the edited label field resets.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://cc.aam-digital.net/child/1
  2. Click on edit data structure
  3. Move name field to another group and change the label
  4. Click save.
  5. See error: name field moved to new group, but not updated the label

Expected behavior
Label should also be saved correctly

Additional context
Not happening on the PR deployment so it seems to have to do with having a real DB.

@sleidig sleidig moved this from Triage to Priority (Core Team) in All Tasks & Issues Jan 22, 2024
@sleidig
Copy link
Member

sleidig commented Jan 23, 2024

It turns out that this is an incompatibility of the new config format. Most instances are using the old array-based entity.attributes. To correctly save and persist changes, the new object-based config for entities is required.

I suggest we run a server-side migration now. The latest app version can handle both config formats, so this should not be noticeable to users. #2066

@sleidig sleidig self-assigned this Jan 23, 2024
@sleidig sleidig moved this from Priority (Core Team) to In Progress in All Tasks & Issues Jan 23, 2024
@sleidig
Copy link
Member

sleidig commented Feb 2, 2024

Config formats have been migrated and updated in CouchDBs now, using ndb-admin API. This bug is thereby fixed.

@sleidig sleidig closed this as completed Feb 2, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in All Tasks & Issues Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants