Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate configs #2066

Closed
2 of 3 tasks
TheSlimvReal opened this issue Nov 8, 2023 · 1 comment
Closed
2 of 3 tasks

Migrate configs #2066

TheSlimvReal opened this issue Nov 8, 2023 · 1 comment
Assignees
Labels
Type: Improvement Improvement/Extension of existing feature with benefit for the user
Milestone

Comments

@TheSlimvReal
Copy link
Collaborator

TheSlimvReal commented Nov 8, 2023

This is a collection issue to collect potential places where it would make sense to migrate the config. Once we do a migration, all of these should be included.

  • EntityListComponent rename property columnGroups to columnGroupsConfig and apply the same to the config property and the interface EntityListConfig (see comment)
  • Align NavigationMenuConfig with MenuItem interface. Currently one uses name and the other uses label. The DashboardShortcutWidgets already uses the MenuItem interface.
  • Add subproperty for HistoricalDataComponent (see fix: show new health an observation records immediately #2187)

To discuss

  • switch the config model a bit: one config doc per entity type? Would allow more useful typing of the Config entity also and group things in a useful way:
class Config extends Entity {
  @DatabaseField() entitySchema: EntitySchema;
  @DatabaseField() viewDetails: EntityDetailsConfig;
  @DatabaseField() viewList: EntityListConfig;
}
@TheSlimvReal TheSlimvReal added the Type: Improvement Improvement/Extension of existing feature with benefit for the user label Nov 8, 2023
@sleidig sleidig added this to the Setup Wizard milestone Nov 8, 2023
@sleidig sleidig moved this from Triage to Priority (Core Team) in All Tasks & Issues Nov 13, 2023
sleidig added a commit that referenced this issue Jan 23, 2024
to align with actually used MenuItem interface

see #2066
@sleidig sleidig self-assigned this Jan 23, 2024
@sleidig sleidig moved this from Priority (Core Team) to In Review in All Tasks & Issues Jan 23, 2024
@sleidig
Copy link
Member

sleidig commented Feb 2, 2024

moved the last remaining config migration point to the related Admin UI ticket: #2067

Let's close this and open new individual issues where needed. With the ConfigService migration function it has become fairly easy to just implement an on-the-fly migration also.

@sleidig sleidig closed this as completed Feb 2, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in All Tasks & Issues Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement Improvement/Extension of existing feature with benefit for the user
Projects
Archived in project
Development

No branches or pull requests

2 participants