feat: generic service for config migrations #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
into which we can easily copy and paste migration functions that have initially been used in the frontend on-the-fly
TheSlimvReal
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Good approach, that makes things quite straight forward. Generally does it make sense to always add/remove endpoints or should we also here just have the list of migrations we want to run and then remove them once the migration has been done? Would make the whole process a bit simpler.
# Conflicts: # src/migration/migration.controller.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
into which we can easily copy and paste migration functions that have initially been used in the frontend on-the-fly
see Aam-Digital/ndb-core#2066