Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Regression] New health checks are not directly added to table #2186

Closed
TheSlimvReal opened this issue Jan 22, 2024 · 2 comments · Fixed by #2187
Closed

[Regression] New health checks are not directly added to table #2186

TheSlimvReal opened this issue Jan 22, 2024 · 2 comments · Fixed by #2187
Assignees
@sleidig
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Type: Bug

Comments

@TheSlimvReal
Copy link
Collaborator

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Child details'
  2. Click on 'Health'
  3. Click '+' button
  4. Fill data
  5. Click 'save'
  6. New entry is not visible in table
  7. After re-entering the view, the entry is visible

Expected behavior
Entry should instantly be visible.

Additional context
This is probably because of the changes in #2142. Now the changes listener is only applied in the RelatedEntitiesComponent, which is not (yet) used in the HealthCheckComponent, and not in the entities table as before.
Its probably easiest to also start using RelatedEntitiesComponent and check whether other components might also be affected by the same issue.
@sleidig sleidig self-assigned this Jan 22, 2024
sleidig added a commit that referenced this issue Jan 22, 2024
@sleidig
fix: show new health an observation records immediately
d622ba8 
fixes #2186
@sleidig sleidig moved this from Triage to In Review in All Tasks & Issues Jan 22, 2024
@sleidig sleidig mentioned this issue Jan 22, 2024
Merged
TheSlimvReal pushed a commit that referenced this issue Jan 22, 2024
@sleidig
fix: show new health an observation records immediately (#2187)
240a34d 
fixes #2186
@github-project-automation github-project-automation bot moved this from In Review to Done in All Tasks & Issues Jan 22, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.29.1-master.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Jan 22, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.30.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleidig sleidig

Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Type: Bug
Projects
All Tasks & Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: show new health an observation records immediately Aam-Digital/ndb-core
3 participants
@sleidig @TheSlimvReal @aam-digital-ci