Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App should request re-login if authentication expired / fails in background #2225

Closed
3 tasks done
sleidig opened this issue Feb 9, 2024 · 3 comments
Closed
3 tasks done
Assignees
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Type: Improvement Improvement/Extension of existing feature with benefit for the user

Comments

@sleidig
Copy link
Member

sleidig commented Feb 9, 2024

We have a few bugs users experience from time to time which are related to the authentication of a user expiring in the app. Currently we do not explicitly handle such cases when a 401 error occurs:

Tasks for implementation (to be discussed):

  • Detect when the current access token expires and automatically get a new one using the refresh token
  • (if still necessary) Catch 401 errors and send people to login screen if the reason is an expired login (or show a popup: "Continue offline or login again?")
  • use overall interceptor in Angular to detect these errors? (and check if some are handled automtically because the refresh token then gets a new valid token)
@sleidig sleidig added the Type: Improvement Improvement/Extension of existing feature with benefit for the user label Feb 9, 2024
@github-project-automation github-project-automation bot moved this to Triage / Analysis in All Tasks & Issues Feb 9, 2024
@sleidig sleidig moved this from Triage / Analysis to Planned (current "sprint") in All Tasks & Issues Mar 1, 2024
@sleidig sleidig moved this from Planned (current "sprint") to Todo (ready for work) in All Tasks & Issues Mar 18, 2024
@sleidig sleidig self-assigned this Mar 20, 2024
@sleidig sleidig moved this from Todo (ready for work) to In Progress in All Tasks & Issues Mar 20, 2024
@sleidig
Copy link
Member Author

sleidig commented Mar 20, 2024

Related errors (in Sentry):

  • No token received from Keycloak (after seeing 401 request failures to /db) 1
  • Errors during HTTP requests for sync bubble up into various error logs (e.g. "Unexpected end of JSON input", "string did not match the expected pattern", "unexpected token '<' is not valid JSON") 1 2 3

sleidig added a commit that referenced this issue Mar 21, 2024
to avoid 401 request failures and related bugs

closes #2225 #2044
@sleidig sleidig moved this from In Progress to In Review in All Tasks & Issues Mar 21, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in All Tasks & Issues Mar 22, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.34.0-master.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Mar 22, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.34.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Type: Improvement Improvement/Extension of existing feature with benefit for the user
Projects
Archived in project
Development

No branches or pull requests

2 participants