Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply some styling to table rows of inactive records #2229

Closed
sleidig opened this issue Feb 12, 2024 · 2 comments · Fixed by #2505
Closed

apply some styling to table rows of inactive records #2229

sleidig opened this issue Feb 12, 2024 · 2 comments · Fixed by #2505
Assignees
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Status: Community Help Wanted (good first issue) simple tasks that don't require understanding every last detail of our platform Type: Improvement Improvement/Extension of existing feature with benefit for the user Type: UX concerning user interface and in a broader sense user experience

Comments

@sleidig
Copy link
Member

sleidig commented Feb 12, 2024

We allow users to include "inactive" (archived) records in list using a toggle below the table. In some views (where we use "ChildBlock", for example) the archived rows can be identified because the have a grey instead of black icon. In other views (e.g. the Schools List) it is impossible to identify which are inactive records.

--> Make the text color for the whole row of an inactive record always dark grey, to help users distinguish these.

This is probably to be set in the entities-table component. For implementation, you could use a conditional css class ("number one" here: https://stackoverflow.com/a/57196493/1473411), checking that rowEntity.isActive is false

image

@sleidig sleidig added Type: UX concerning user interface and in a broader sense user experience Type: Improvement Improvement/Extension of existing feature with benefit for the user Status: Community Help Wanted (good first issue) simple tasks that don't require understanding every last detail of our platform labels Feb 12, 2024
@github-project-automation github-project-automation bot moved this to Triage / Analysis in All Tasks & Issues Feb 12, 2024
@sleidig sleidig moved this from Triage / Analysis to Todo (ready for work) in All Tasks & Issues Feb 23, 2024
@sleidig sleidig moved this from Todo (ready for work) to In Progress in All Tasks & Issues Aug 8, 2024
sleidig pushed a commit that referenced this issue Aug 12, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in All Tasks & Issues Aug 12, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.40.0-master.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Aug 12, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.40.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Status: Community Help Wanted (good first issue) simple tasks that don't require understanding every last detail of our platform Type: Improvement Improvement/Extension of existing feature with benefit for the user Type: UX concerning user interface and in a broader sense user experience
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants