Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Notes popup immediately dismissed as user is forwarded to Keycloak Login #2365

Closed
sleidig opened this issue Apr 25, 2024 · 2 comments · Fixed by #2449
Closed

Release Notes popup immediately dismissed as user is forwarded to Keycloak Login #2365

sleidig opened this issue Apr 25, 2024 · 2 comments · Fixed by #2449
Assignees
@sleidig
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Type: Bug

Comments

@sleidig
Copy link
Member

sleidig commented Apr 25, 2024

Whenever a new app update has been loaded, we display a popup with release notes for the user. However, as the user gets forward to the (external) Keycloak Login automatically nowadays, this popup is dismissed and not displayed again.

--> pause forward to Keycloak until Release Notes closed?
--> Or only show release notes after login?
@github-project-automation github-project-automation bot moved this to Triage / Analysis in All Tasks & Issues Apr 25, 2024
@sleidig sleidig moved this from Triage / Analysis to In Review in All Tasks & Issues Jul 3, 2024
@sleidig sleidig self-assigned this Jul 3, 2024
sleidig added a commit that referenced this issue Jul 3, 2024
@sleidig
fix(login): do not dismiss "latest changes" dialog automatically duri…
e624afa 
…ng login

fixes #2365
@sleidig sleidig mentioned this issue Jul 3, 2024
Merged
sleidig added a commit that referenced this issue Jul 3, 2024
@sleidig
fix(login): do not dismiss "latest changes" dialog automatically duri…
d60f1bc 
…ng login

fixes #2365
@github-project-automation github-project-automation bot moved this from In Review to Done in All Tasks & Issues Jul 3, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.38.2-master.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Jul 3, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.38.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleidig sleidig

Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Type: Bug
Projects
All Tasks & Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/release notes popup dismissed Aam-Digital/ndb-core
2 participants
@sleidig @aam-digital-ci