Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public Forms throw error on invalid submission instead of showing user feedback #2445

Closed
sentry-io bot opened this issue Jul 2, 2024 · 2 comments · Fixed by #2446
Closed

Public Forms throw error on invalid submission instead of showing user feedback #2445

sentry-io bot opened this issue Jul 2, 2024 · 2 comments · Fixed by #2446
Assignees
@sleidig
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Type: Bug

Comments

@sentry-io
Copy link

sentry-io bot commented Jul 2, 2024

To reproduce: try to submit a public form with required fields empty -> console logs error but no clear message is shown to user.

Sentry Issue: AAM-DIGITAL-5KB

Error: Invalid form fields
  at new InvalidFormFieldError (./src/app/core/common-components/entity-form/invalid-form-field.error.ts:6:5)
  at EntityFormService.checkFormValidity (./src/app/core/common-components/entity-form/entity-form.service.ts:242:3)
  at key (./src/app/core/common-components/entity-form/entity-form.service.ts:212:10)
  at {PublicFormComponent#2}.submit (./src/app/features/public-form/public-form.component.ts:60:8)
...
(13 additional frame(s) were not displayed)
@sentry-io sentry-io bot added the Type: Bug label Jul 2, 2024
@github-project-automation github-project-automation bot moved this to Triage / Analysis in All Tasks & Issues Jul 2, 2024
@sleidig sleidig moved this from Triage / Analysis to In Progress in All Tasks & Issues Jul 2, 2024
@sleidig sleidig moved this from In Progress to In Review in All Tasks & Issues Jul 2, 2024
sleidig added a commit that referenced this issue Jul 2, 2024
@sleidig
fix(public forms): show info to user submitting invalid form
e5c2b31 
instead of throwing error in background

fixes #2445
@sleidig sleidig linked a pull request Jul 2, 2024 that will close this issue
Various bug fixes & logging improvements #2446
Merged
sleidig added a commit that referenced this issue Jul 2, 2024
@sleidig
fix(public forms): show info to user submitting invalid form
7bc360f 
instead of throwing error in background

fixes #2445
@github-project-automation github-project-automation bot moved this from In Review to Done in All Tasks & Issues Jul 2, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.38.1-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Jul 2, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.38.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleidig sleidig

Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Type: Bug
Projects
All Tasks & Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Various bug fixes & logging improvements Aam-Digital/ndb-core
2 participants
@sleidig @aam-digital-ci