Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attendance Overview tab in Child Details should hide archived #2587

Closed
sleidig opened this issue Sep 30, 2024 · 2 comments · Fixed by #2616
Closed

Attendance Overview tab in Child Details should hide archived #2587

sleidig opened this issue Sep 30, 2024 · 2 comments · Fixed by #2616
Assignees
@Abhinegi2
Labels
Client: by X released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Type: Improvement Improvement/Extension of existing feature with benefit for the user

Comments

@sleidig
Copy link
Member

sleidig commented Sep 30, 2024

Child Details -> Attendance shows one tab for each recurring activity. This can become very long and confusing:

  • show only tabs for those recurring activities that are active (isActive = true)
  • show one additional tab "previous activities" and within that list all the other, archived activities' attendance overviews (either below each other or with a dropdown to select one of the archived activties for which to see attendance)
@sleidig sleidig added the Type: Improvement Improvement/Extension of existing feature with benefit for the user label Sep 30, 2024
@github-project-automation github-project-automation bot moved this to Triage / Analysis in All Tasks & Issues Sep 30, 2024
@Abhinegi2 Abhinegi2 self-assigned this Oct 14, 2024
@Abhinegi2 Abhinegi2 mentioned this issue Oct 15, 2024
Merged
1 task
@sleidig sleidig moved this from In Progress to In Review in All Tasks & Issues Oct 18, 2024
sleidig pushed a commit that referenced this issue Oct 18, 2024
@Abhinegi2
fix(attendance): attendance overview tab lists archived activities se…
ac59557 
…parately (#2616)

closes #2587
@github-project-automation github-project-automation bot moved this from In Review to Done in All Tasks & Issues Oct 18, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.42.2-master.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Oct 18, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.42.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Oct 24, 2024
sleidig pushed a commit that referenced this issue Nov 15, 2024
@Abhinegi2 @sleidig
fix(attendance): attendance overview tab lists archived activities se…
87f8ab0 
…parately (#2616)

closes #2587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abhinegi2 Abhinegi2

Labels
Client: by X released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Type: Improvement Improvement/Extension of existing feature with benefit for the user
Projects
All Tasks & Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Attendance Overview tab in Child Details should hide archived Aam-Digital/ndb-core
3 participants
@sleidig @aam-digital-ci @Abhinegi2