Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard widgets should allow overwriting label / title #2594

Closed
sleidig opened this issue Oct 2, 2024 · 3 comments · Fixed by #2656
Closed

Dashboard widgets should allow overwriting label / title #2594

sleidig opened this issue Oct 2, 2024 · 3 comments · Fixed by #2656
Assignees
@sleidig @sadaf895
Labels
Client: by X released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Type: Improvement Improvement/Extension of existing feature with benefit for the user

Comments

@sleidig
Copy link
Member

sleidig commented Oct 2, 2024 •
edited
Loading

if the widget config object defines a subtitle or explanation, that should be passed through to the base EntityDashboardWidgetComponent and overwrite whatever subtitle a special widget like EntityCountDashboard may otherwise generate automatically.
@sleidig sleidig added the Type: Improvement Improvement/Extension of existing feature with benefit for the user label Oct 2, 2024
@github-project-automation github-project-automation bot moved this to Triage / Analysis in All Tasks & Issues Oct 2, 2024
@Abhinegi2 Abhinegi2 self-assigned this Oct 16, 2024
@sleidig sleidig moved this from In Progress to Todo (ready for work) in All Tasks & Issues Oct 21, 2024
@sleidig
Copy link
Member Author

sleidig commented Nov 4, 2024

This probably means the following for implementation:

  • add @Input() properties to each of the different dashboard widget components for subtitle, explanation
  • in the templates, pass into the <app-entity-dashboard... as subtitle etc. in a way that uses this input if it is given (e.g. for EntityCountDashboard: [subtitle]="subtitle ?? label" = use subtitle if defined, otherwise the "label" which holds the value designed as default for the entity-count dashboard)

@sadaf895 sadaf895 mentioned this issue Nov 12, 2024
Merged
@sleidig sleidig self-assigned this Nov 12, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in All Tasks & Issues Nov 14, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.43.0-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Nov 14, 2024
sleidig pushed a commit that referenced this issue Nov 15, 2024
@sadaf895 @sleidig
feat(core): make subtitle and explanation for all dashboard widgets o…
e0e2298 
…verwritable via config (#2656)

closes #2594
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.43.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleidig sleidig

@sadaf895 sadaf895

Labels
Client: by X released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Type: Improvement Improvement/Extension of existing feature with benefit for the user
Projects
All Tasks & Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add configurable subtitle and explanation inputs Aam-Digital/ndb-core
4 participants
@sleidig @aam-digital-ci @Abhinegi2 @sadaf895