feat: add configurable subtitle and explanation inputs #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `subtitle` and `explanation` as configurable inputs for the `EntityCountDashboard` component - Updated template to display `subtitle` and `explanation` from the configuration, falling back to defaults if not provided - Modified widget configuration to support customizable subtitles and explanations for enhanced clarity
|
@sleidig Can you please tell me what will be my further step? |
sleidig
reviewed
Nov 12, 2024
There was a problem hiding this comment.
Looks good so far!
(Did you test it without the config-fix change also, to see that the default logic still works correctly?)
For the other widgets we'll have to do the exact same thing, adding those two Input properties. I discussed with Tom but we didn't see a way to nicely generalize that
...s/entity-count-dashboard-widget/entity-count-dashboard/entity-count-dashboard.component.html
Outdated
Show resolved
Hide resolved
…et/entity-count-dashboard/entity-count-dashboard.component.html Co-authored-by: Sebastian <sebastian@aam-digital.com>
Yes, I have tested it the default logic is working without the config-fix change. |
sleidig
reviewed
Nov 13, 2024
...t/notes/dashboard-widgets/important-notes-dashboard/important-notes-dashboard.component.html
Outdated
Show resolved
Hide resolved
sleidig
reviewed
Nov 13, 2024
...board-widgets/birthday-dashboard-widget/birthday-dashboard/birthday-dashboard.component.html
Outdated
Show resolved
Hide resolved
...s/entity-count-dashboard-widget/entity-count-dashboard/entity-count-dashboard.component.html
Outdated
Show resolved
Hide resolved
...board-widgets/progress-dashboard-widget/progress-dashboard/progress-dashboard.component.html
Outdated
Show resolved
Hide resolved
…tes-dashboard/important-notes-dashboard.component.html Co-authored-by: Sebastian <sebastian@aam-digital.com>
…et/entity-count-dashboard/entity-count-dashboard.component.html Co-authored-by: Sebastian <sebastian@aam-digital.com>
…rogress-dashboard/progress-dashboard.component.html Co-authored-by: Sebastian <sebastian@aam-digital.com>
|
@sleidig Please review the updated code. |
sleidig
requested changes
Nov 13, 2024
...t/notes/dashboard-widgets/important-notes-dashboard/important-notes-dashboard.component.html
Outdated
Show resolved
Hide resolved
...shboard-widgets/shortcut-dashboard-widget/shortcut-dashboard/shortcut-dashboard.component.ts
Outdated
Show resolved
Hide resolved
src/app/features/todos/todos-dashboard/todos-dashboard.component.html
Outdated
Show resolved
Hide resolved
...board-widgets/shortcut-dashboard-widget/shortcut-dashboard/shortcut-dashboard.component.html
Outdated
Show resolved
Hide resolved
...board-widgets/progress-dashboard-widget/progress-dashboard/progress-dashboard.component.html
Outdated
Show resolved
Hide resolved
...s/entity-count-dashboard-widget/entity-count-dashboard/entity-count-dashboard.component.html
Outdated
Show resolved
Hide resolved
...ets/entity-count-dashboard-widget/entity-count-dashboard/entity-count-dashboard.component.ts
Outdated
Show resolved
Hide resolved
...board-widgets/birthday-dashboard-widget/birthday-dashboard/birthday-dashboard.component.html
Outdated
Show resolved
Hide resolved
...ect/notes/dashboard-widgets/important-notes-dashboard/important-notes-dashboard.component.ts
Outdated
Show resolved
Hide resolved
…tes-dashboard/important-notes-dashboard.component.html Co-authored-by: Sebastian <sebastian@aam-digital.com>
…hortcut-dashboard/shortcut-dashboard.component.ts Co-authored-by: Sebastian <sebastian@aam-digital.com>
…hortcut-dashboard/shortcut-dashboard.component.html Co-authored-by: Sebastian <sebastian@aam-digital.com>
…et/entity-count-dashboard/entity-count-dashboard.component.html Co-authored-by: Sebastian <sebastian@aam-digital.com>
…et/entity-count-dashboard/entity-count-dashboard.component.ts Co-authored-by: Sebastian <sebastian@aam-digital.com>
…irthday-dashboard/birthday-dashboard.component.html Co-authored-by: Sebastian <sebastian@aam-digital.com>
…tes-dashboard/important-notes-dashboard.component.ts Co-authored-by: Sebastian <sebastian@aam-digital.com>
sleidig
reviewed
Nov 13, 2024
src/app/features/todos/todos-dashboard/todos-dashboard.component.ts
Outdated
Show resolved
Hide resolved
|
🎉 This PR is included in version 3.43.0-master.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2594