Paginator for tables #445
Merged
Paginator for tables #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleidig
reviewed
May 30, 2020
...ect/notes/dashboard-widgets/no-recent-notes-dashboard/no-recent-notes-dashboard.component.ts
Outdated
Show resolved
Hide resolved
sleidig
reviewed
May 30, 2020
# Conflicts: # src/app/child-dev-project/children/children-list/children-list.component.ts # src/app/child-dev-project/children/children.module.ts # src/app/child-dev-project/notes/dashboard-widgets/no-recent-notes-dashboard/no-recent-notes-dashboard.component.ts # src/app/child-dev-project/schools/schools-list/schools-list.component.ts
sleidig
force-pushed
the
paginator_for_tables
branch
from
800289b to
28fedfb
Compare
Co-authored-by: Sebastian <sebastian.leidig@gmail.com>
vlle1
reviewed
Jun 9, 2020
src/app/child-dev-project/children/children-list/children-list.component.html
Outdated
Show resolved
Hide resolved
src/app/child-dev-project/children/children-list/children-list.component.html
Outdated
Show resolved
Hide resolved
| @@ -19,7 +19,7 @@ export class NotePresenceListComponent implements OnChanges { | |||
| @Input() recordForm: NgForm; | |||
| smallScreen: boolean; | |||
|
|
|||
| @ViewChild("childSelect") | |||
| @ViewChild("childSelect", { static: true }) | |||
There was a problem hiding this comment.
Suggested change
| @ViewChild("childSelect", { static: true }) | |
| @ViewChild("childSelect") |
| }) | ||
| export class SchoolsListComponent implements OnInit, AfterViewInit { | ||
| schoolList: School[]; | ||
| schoolDataSource: MatTableDataSource<School> = new MatTableDataSource< | ||
| School | ||
| >(); | ||
|
|
||
| @ViewChild(MatSort) sort: MatSort; | ||
| @ViewChild(MatSort, { static: false }) sort: MatSort; |
There was a problem hiding this comment.
Suggested change
| @ViewChild(MatSort, { static: false }) sort: MatSort; | |
| @ViewChild(MatSort) sort: MatSort; |
| }) | ||
| export class SchoolsListComponent implements OnInit, AfterViewInit { | ||
| schoolList: School[]; | ||
| schoolDataSource: MatTableDataSource<School> = new MatTableDataSource< | ||
| School | ||
| >(); | ||
|
|
||
| @ViewChild(MatSort) sort: MatSort; | ||
| @ViewChild(MatSort, { static: false }) sort: MatSort; | ||
| @ViewChild(MatPaginator, { static: false }) paginator: MatPaginator; |
There was a problem hiding this comment.
Suggested change
| @ViewChild(MatPaginator, { static: false }) paginator: MatPaginator; | |
| @ViewChild(MatPaginator) paginator: MatPaginator; |
sleidig
pushed a commit
that referenced
this pull request
Jun 27, 2020
# [2.14.0](2.13.2...2.14.0) (2020-06-27) ### Bug Fixes * prevent error log message about serviceworker not available ([a2eebf9](a2eebf9)) * **dashboard:** improve styling of recent-notes dashboard widgets ([4355ea4](4355ea4)) * **note:** prevent disappearing of children linked in notes ([4aba52b](4aba52b)) * **notes:** add full width to notes table ([7eef007](7eef007)), closes [#457](#457) [#458](#458) * **search:** improve search: loading indication and other hints ([6995476](6995476)), closes [#366](#366) [#456](#456) ### Features * add pagination to tables ([87cddde](87cddde)), closes [#381](#381) [#445](#445) * **conflict-resolution:** view and resolve pouchdb document conflicts ([2a84025](2a84025)), closes [#79](#79) [#393](#393) * **latest-changes:** display changelog based on GitHub Release information ([7226f08](7226f08)), closes [#238](#238)
|
🎉 This PR is included in version 2.14.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue: #381
Visible/Frontend Changes
Architectural/Backend Changes