Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): fix weird behaving in search bar #456

Merged
merged 6 commits into from
Jun 27, 2020
Merged

Conversation

tomwwinter
Copy link
Contributor

see issue: #366

Visible/Frontend Changes

  • show current state of the search is displayed ("Searching", "No Results", ..)
  • wait a short time before search input triggers a search (user typing)
  • minimum of three characters in search

Architectural/Backend Changes

  • An already running search is cancelled (technically only ignored) and replaced with the new search query (switchMap)

Closing #366

Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For an instant the search shows "No results" before switching to "Search in progress". Otherwise this looks quite good!

src/app/core/ui/search/search.component.ts Outdated Show resolved Hide resolved
src/app/core/ui/search/search.component.ts Outdated Show resolved Hide resolved
src/app/core/ui/search/search.component.html Show resolved Hide resolved
@sleidig sleidig merged commit 6995476 into master Jun 27, 2020
@sleidig sleidig deleted the bug-366-search-bar branch June 27, 2020 12:07
sleidig pushed a commit that referenced this pull request Jun 27, 2020
# [2.14.0](2.13.2...2.14.0) (2020-06-27)

### Bug Fixes

* prevent error log message about serviceworker not available ([a2eebf9](a2eebf9))
* **dashboard:** improve styling of recent-notes dashboard widgets ([4355ea4](4355ea4))
* **note:** prevent disappearing of children linked in notes ([4aba52b](4aba52b))
* **notes:** add full width to notes table ([7eef007](7eef007)), closes [#457](#457) [#458](#458)
* **search:** improve search: loading indication and other hints ([6995476](6995476)), closes [#366](#366) [#456](#456)

### Features

* add pagination to tables ([87cddde](87cddde)), closes [#381](#381) [#445](#445)
* **conflict-resolution:** view and resolve pouchdb document conflicts ([2a84025](2a84025)), closes [#79](#79) [#393](#393)
* **latest-changes:** display changelog based on GitHub Release information ([7226f08](7226f08)), closes [#238](#238)
@sleidig
Copy link
Member

sleidig commented Jun 27, 2020

🎉 This PR is included in version 2.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants