Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build menu from a configuration object #501

Closed
5 tasks done
TheSlimvReal opened this issue Sep 22, 2020 · 1 comment
Closed
5 tasks done

Build menu from a configuration object #501

TheSlimvReal opened this issue Sep 22, 2020 · 1 comment
Labels
Status: Community Help Wanted (good first issue) simple tasks that don't require understanding every last detail of our platform Type: Improvement Improvement/Extension of existing feature with benefit for the user Type: Refactoring / Technical Enh. Technical Enhancement without changes for the user

Comments

@TheSlimvReal
Copy link
Collaborator

TheSlimvReal commented Sep 22, 2020

The top level menu is already very dynamic in its creation. For each button, a menu item is added in the app.module.ts. This process should be automated. The input will be an array of configuration objects and for each of these objects, a menu button will be added.
The configuration objects should at least consist of the name of the menu button, the icon which will be displayed next to the name and the component to which this button links.

Steps to do:

  • Create a structure for the configuration object
  • Create a function which gets an array of configuration objects and creates an menu button for each object
  • Replace old procedure by this new one
  • Write tests for these methods
  • Optional: Also create routes and guards from the same configuration object (app.routing.ts)

relates to #222

@TheSlimvReal TheSlimvReal added Type: Refactoring / Technical Enh. Technical Enhancement without changes for the user Type: Improvement Improvement/Extension of existing feature with benefit for the user Status: Community Help Wanted (good first issue) simple tasks that don't require understanding every last detail of our platform labels Sep 22, 2020
@sleidig sleidig added the PPI label Sep 28, 2020
@TheSlimvReal TheSlimvReal mentioned this issue Sep 29, 2020
7 tasks
sleidig added a commit that referenced this issue Oct 20, 2020
…om config

see #501, #120 (and overall: #222)
 (PR #514)


Co-authored-by: Simon <therealslimv@yahoo.de>
Co-authored-by: Richard Nutt <richard.nutt-privat@outlook.com>
aam-digital-ci pushed a commit that referenced this issue Oct 20, 2020
# [2.20.0](2.19.1...2.20.0) (2020-10-20)

### Features

* dynamically generate routing, navigation, menu, dashboard from config ([244026a](244026a)), closes [#501](#501) [#120](#120) [#222](#222) [#514](#514)
@sleidig
Copy link
Member

sleidig commented Oct 20, 2020

done with #510 / #504

@sleidig sleidig closed this as completed Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Community Help Wanted (good first issue) simple tasks that don't require understanding every last detail of our platform Type: Improvement Improvement/Extension of existing feature with benefit for the user Type: Refactoring / Technical Enh. Technical Enhancement without changes for the user
Projects
None yet
Development

No branches or pull requests

2 participants