Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sentry/Color fixes #528

Merged
merged 12 commits into from
Nov 24, 2020
Merged

Sentry/Color fixes #528

merged 12 commits into from
Nov 24, 2020

Conversation

RichardNutt
Copy link
Contributor

@RichardNutt RichardNutt commented Nov 3, 2020 •
edited
Loading

see issue: #515 #516 #529

This should fix the sentry errors. Unfortunately I was not able to reproduce the errors myself.

Also fixes the issue that colors were missing in the child notes tab. (I included this here since otherwise this would probably lead to merge conflicts due to the other changes.)

Architectural/Backend Changes

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2020

Deployed to https://aam-digital.github.io/ndb-core/deployments/sentry-fixes

@RichardNutt RichardNutt changed the title Sentry fixes [WIP] Sentry fixes Nov 8, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2020

Deployed to https://aam-digital.github.io/ndb-core/deployments/sentry-fixes

@RichardNutt RichardNutt changed the title [WIP] Sentry fixes [WIP] Sentry/Color fixes Nov 8, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2020

Deployed to https://aam-digital.github.io/ndb-core/deployments/sentry-fixes

@RichardNutt RichardNutt changed the title [WIP] Sentry/Color fixes Sentry/Color fixes Nov 9, 2020
@RichardNutt RichardNutt linked an issue Nov 9, 2020 that may be closed by this pull request
No Colors in Notes of Child #529
Closed
@RichardNutt RichardNutt self-assigned this Nov 9, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2020

Deployed to https://aam-digital.github.io/ndb-core/deployments/sentry-fixes

TheSlimvReal
TheSlimvReal approved these changes Nov 10, 2020
View reviewed changes
Copy link
Collaborator

@TheSlimvReal TheSlimvReal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very clean. Good work

@github-actions
Copy link
Contributor

Deployed to https://aam-digital.github.io/ndb-core/deployments/sentry-fixes

@github-actions
Copy link
Contributor

Deployed to https://aam-digital.github.io/ndb-core/deployments/sentry-fixes

@sleidig sleidig merged commit 81fada1 into master Nov 24, 2020
@sleidig sleidig deleted the sentry-fixes branch November 24, 2020 18:46
aam-digital-ci pushed a commit that referenced this pull request Nov 24, 2020
@semantic-release-bot
chore(release): 2.20.2 [skip ci]
d019a44 
## [2.20.2](2.20.1...2.20.2) (2020-11-24)

### Bug Fixes

* fix various minor bugs and warnings ([#528](#528)) ([81fada1](81fada1)), closes [#515](#515) [#516](#516) [#529](#529) [#529](#529)
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 2.20.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleidig sleidig sleidig left review comments

@TheSlimvReal TheSlimvReal TheSlimvReal approved these changes

Assignees

@RichardNutt RichardNutt

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@RichardNutt @aam-digital-ci @sleidig @TheSlimvReal