Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Colors in Notes of Child #529

Closed
TheSlimvReal opened this issue Nov 6, 2020 · 1 comment · Fixed by #528
Closed

No Colors in Notes of Child #529

TheSlimvReal opened this issue Nov 6, 2020 · 1 comment · Fixed by #528
Assignees
@RichardNutt

Comments

@TheSlimvReal
Copy link
Collaborator

Describe the bug
The notes-of-child-child component should color the entries based on the type of note.
This still works on the demo deployment, but does not work on the current master.
It got probably introduced with the color changes in #521.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Child Details'
  2. Click on 'Notes and Reports'
  3. See that entries are all white

Expected behavior
The entries should have colors based on the note type

Screenshots
Demo:
demo

Master:
master
@TheSlimvReal TheSlimvReal mentioned this issue Nov 6, 2020
Merged
@RichardNutt RichardNutt self-assigned this Nov 8, 2020
RichardNutt added a commit that referenced this issue Nov 8, 2020
@RichardNutt
fixes #529
8a24c8a
@RichardNutt RichardNutt mentioned this issue Nov 8, 2020
Merged
4 tasks
@RichardNutt RichardNutt linked a pull request Nov 9, 2020 that will close this issue
Sentry/Color fixes #528
Merged
4 tasks
sleidig pushed a commit that referenced this issue Nov 24, 2020
@RichardNutt
fix(*): fix various minor bugs and warnings (#528)
81fada1 
 added undefined/null check to fix #515
 moved the getColor function to notes-of-child to fix #516
 fixed demo data in light of #529
 fixed getColorForId()/getColor() to fix  #529
aam-digital-ci pushed a commit that referenced this issue Nov 24, 2020
@semantic-release-bot
chore(release): 2.20.2 [skip ci]
d019a44 
## [2.20.2](2.20.1...2.20.2) (2020-11-24)

### Bug Fixes

* fix various minor bugs and warnings ([#528](#528)) ([81fada1](81fada1)), closes [#515](#515) [#516](#516) [#529](#529) [#529](#529)
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 2.20.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RichardNutt RichardNutt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sentry/Color fixes Aam-Digital/ndb-core
3 participants
@RichardNutt @TheSlimvReal @aam-digital-ci