You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The edit button for details forms is already used in a lot of components. it would make sense to move it to a general component, so the styling and behavior is consistent.
This changes should move the edit, save and cancel button into a single component which provides the input parameter entity which is used to determine whether the current user is allowed to use the button as well as two output even emitters to notify about clicks on the save and cancel button.
There might be a problem where the save function runs some additional checks before actually saving the entity which eventually can fail. So maybe instead of using output parameters, it might make more sense to pass the function which should be run, once the save button is clicked, into the component.
I think this has become obsolete as the logic is now already centralized in the EntityFormComponent that is used everywhere for these kind of forms since PR #817.
The edit button for details forms is already used in a lot of components. it would make sense to move it to a general component, so the styling and behavior is consistent.
Originally posted by @TheSlimvReal in #560 (comment)
The text was updated successfully, but these errors were encountered: