Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize the edit button of detail forms #574

Closed
sleidig opened this issue Dec 19, 2020 · 2 comments
Closed

Generalize the edit button of detail forms #574

sleidig opened this issue Dec 19, 2020 · 2 comments
Assignees
Labels
Type: Refactoring / Technical Enh. Technical Enhancement without changes for the user

Comments

@sleidig
Copy link
Member

sleidig commented Dec 19, 2020

The edit button for details forms is already used in a lot of components. it would make sense to move it to a general component, so the styling and behavior is consistent.

Originally posted by @TheSlimvReal in #560 (comment)

@sleidig sleidig added Status: Ready to Work On Type: Refactoring / Technical Enh. Technical Enhancement without changes for the user labels Dec 19, 2020
@Schottkyc137 Schottkyc137 self-assigned this Jun 12, 2021
@Schottkyc137 Schottkyc137 mentioned this issue Jun 12, 2021
2 tasks
@TheSlimvReal
Copy link
Collaborator

This changes should move the edit, save and cancel button into a single component which provides the input parameter entity which is used to determine whether the current user is allowed to use the button as well as two output even emitters to notify about clicks on the save and cancel button.
There might be a problem where the save function runs some additional checks before actually saving the entity which eventually can fail. So maybe instead of using output parameters, it might make more sense to pass the function which should be run, once the save button is clicked, into the component.

@sleidig
Copy link
Member Author

sleidig commented Jul 26, 2021

I think this has become obsolete as the logic is now already centralized in the EntityFormComponent that is used everywhere for these kind of forms since PR #817.

@sleidig sleidig closed this as completed Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactoring / Technical Enh. Technical Enhancement without changes for the user
Projects
None yet
Development

No branches or pull requests

3 participants