Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect datatypes with components #817

Merged
merged 247 commits into from
Jul 2, 2021
Merged

Connect datatypes with components #817

merged 247 commits into from
Jul 2, 2021

Conversation

TheSlimvReal
Copy link
Collaborator

@TheSlimvReal TheSlimvReal commented May 13, 2021 •
edited
Loading

see issue: #764 #552 #180 #826

Visible/Frontend Changes

--

Architectural/Backend Changes

  • EntitySchema holds information how an attribute can be displayed
  • EntitySchema holds information how an attribute can be edited
  • EntitySchemaDatatype provides a default component for displaying an data type
  • EntitySchemaDatatype provides a default component for editing an data type
  • EntityListComponent automatically fetches column information from schema if no other definition is found
  • FormComponent automatically fetches form field information from schema if no other definition is found
  • EntitySubrecord automatically fetches display and edit information from schema if no other definition is found
  • EntityList uses EntitySubrecord
  • Automatically create filters for properties using schema information
  • Update documentation
  • Automatically create (popup) form for entities -> Automatic PopUps #834

@github-actions
Copy link
Contributor

Deployed to https://test-deployment-pr-817.herokuapp.com/

TheSlimvReal added 21 commits May 14, 2021 07:58
@TheSlimvReal
refactored some names
8846898
@TheSlimvReal
form component adds additional information from schemas
ad6f5d6
@TheSlimvReal
refactored getComponent function
948341f
@TheSlimvReal
cleaned up from component
ed945b9
@TheSlimvReal
added dynamic textfield component
60dbdac
@TheSlimvReal
refactored form component and edit components
0fbf0a8
@TheSlimvReal
copied setup code from edit text component
65edf3f
@TheSlimvReal
added dynamic edit configurable enum component
a79a607
@TheSlimvReal
refactored the config that is passed between form and edit components
9af5468
@TheSlimvReal
fixed error messages
4c82d1f
@TheSlimvReal
added component to edit dates
22ccdbd
@TheSlimvReal
added component to edit selectables
e44a258
@TheSlimvReal
added component to calcualte the age
5678cb9
@TheSlimvReal
adding component for editing booleans
0f7e325
@TheSlimvReal
implement edit boolean component
b75138b
@TheSlimvReal
added component to edit long texts
0dcbf93
@TheSlimvReal
added component for editing photo files
ced5a0a
@TheSlimvReal
added new datatype for displaying photos
178c664
@TheSlimvReal
using new datatype for editing photos in form
57dcea1
@TheSlimvReal
using the new specialPhoto everywhere
5e3bd5b
@TheSlimvReal
added tests for photo datatype
55b3bbf
sleidig and others added 20 commits June 30, 2021 17:41
@sleidig
simplify child fields for health
8dbb469
@TheSlimvReal
removing label and display text components
f74dd5e
@TheSlimvReal
updating input entity
501b430
@TheSlimvReal
changed the saved lables
f894c4b
@TheSlimvReal
fixed assignedTo conversion
aedd6c7
@TheSlimvReal
fixed bug where for configurable enum filters
acb4a66
@TheSlimvReal
moved sorting accessor
24e4353
@TheSlimvReal
fixed filtering accessor
bfdaf39
@TheSlimvReal
fixed entity-form story
975c0d6
@TheSlimvReal
fixed changed after has been checked error
e8f1f3f
@TheSlimvReal
fixed boolean filter default issue
c6b6031
@TheSlimvReal
Merge branch 'review-fixes' into connect-datatypes-with-components
ee20f7c 
# Conflicts:
#	src/app/child-dev-project/educational-material/model/materials.ts
#	src/app/core/config/config-migration.service.spec.ts
#	src/app/core/config/config-migration.service.ts
#	src/app/core/entity-components/entity-form/entity-form.service.spec.ts
#	src/app/core/entity-components/entity-form/entity-form.service.ts
#	src/app/core/entity-components/entity-form/entity-form/entity-form.component.ts
#	src/app/core/entity-components/entity-form/entity-form/entity-form.stories.ts
#	src/app/core/entity-components/entity-list/entity-list.component.ts
@TheSlimvReal
fixed boolean filter default issue
9e2df4a
@TheSlimvReal
Merge branch 'master' into connect-datatypes-with-components
3d0a7f5
@TheSlimvReal
updated entity subrecord documentation
d86d7cf
@TheSlimvReal
added documentation for schema system
b9873e5
@TheSlimvReal
updated documentation for config system
4a87530
@TheSlimvReal
added migration for assignedTo filters
96ae9dd
@TheSlimvReal
Merge remote-tracking branch 'origin/connect-datatypes-with-component…
26f0d4a 
…s' into connect-datatypes-with-components
@sleidig
hide entity-select input field when disabled while still avoiding cha…
68d7abd 
…nged after checked error
@ghost
Copy link

ghost commented Jul 2, 2021

DeepCode's analysis on #68d7ab found:

  • ⚠️ 2 warnings, ℹ️ 2 minor issues. 👇
  • ✔️ 3 issues were fixed.

Top issues

Description Example fixes
The usage of regex in replace will change only the first match. Consider using a regular expression with the global replacement flag (/g) to replace all occurrences. Occurrences: 🔧 Example fixes
Be aware that month indices used in Date are 0-based (0 = January, 1 = February, ...). Occurrences: 🔧 Example fixes
Use an array literal instead of the Array constructor. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

👉 The DeepCode service and API will be deprecated in August, 2021. Here is the information how to migrate. Thank you for using DeepCode 🙏 ❤️ !

If you are using our plugins, you might be interested in their successors: Snyk's JetBrains plugin and Snyk's VS Code plugin.

sleidig
sleidig approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with the entity-select is actually independent of this PR, also occuring in master (--> #872)

Looks good otherwise now!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 2, 2021

SonarCloud Quality Gate failed.

Bug D 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 22 Code Smells

No Coverage information No Coverage information
3.5% 3.5% Duplication

@sleidig sleidig merged commit 4320781 into master Jul 2, 2021
@sleidig sleidig deleted the connect-datatypes-with-components branch July 2, 2021 22:13
aam-digital-ci pushed a commit that referenced this pull request Jul 2, 2021
@semantic-release-bot
chore(release): 2.52.0
b870914 
# [2.52.0](2.51.1...2.52.0) (2021-07-02)

### Features

* connect datatypes with components to simplify config ([#817](#817)) ([4320781](4320781)), closes [#764](#764) [#552](#552) [#180](#180) [#826](#826) [#834](#834)
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 2.52.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

This was referenced Jul 26, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleidig sleidig sleidig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheSlimvReal @aam-digital-ci @sleidig