Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow activities to be added from school details view #713

Closed
sleidig opened this issue Mar 14, 2021 · 4 comments
Closed

Allow activities to be added from school details view #713

sleidig opened this issue Mar 14, 2021 · 4 comments
Assignees

Comments

@sleidig
Copy link
Member

sleidig commented Mar 14, 2021

Allow users to see (and add/remove) activities (RecurringActivity) from the school details view. At the moment this is only possible the other way around: From the Activity details view you can add a school/group to a given activity but some users have a different workflow.

Suggested Solution:

  • additional tab in team/school details: "Activities"
  • in the tab: subrecord-entity list similar to the "Participants" tab listing all activities the team is linked to and allowing to add new ones
  • no inline editing, popup to show all the (custom config) fields of activity information for each row

creating a new recurring activity:

  • show popup with all empty activity fields
  • on save: create new RecurringActivity

second phase implementation

adding the school to an existing recurring activity:

  1. User clicks "+" to add an activity
  2. User types a "title" in the field, this functions like an entity select showing all recurring activites
  3. User selects an existing recurring activity
  4. Form updates, showing the values (e.g. assigned users, etc.) of that existing activity
  5. Form automatically adds the current school as one of the "groups"
  6. User can save this to update the existing activity.

(as described below by in comment)

  • Load all RecrringActivities with the EntityMapperService
  • Display the RecurringActivities in a input with autocomplete
  • Add a button Add school to activity
  • Clicking button should add the ID of the school to the linkedGroups array of the RecrurringActivity that is selected in the input field and save it with the entity mapper

this would ideally be integrated in the same form used to create a new activity, maybe making the title field auto-complete but also allow a new title to create a new activity.
As this is more complex, suggesting to implement this feature in two phases. The most common use case will be creating entirely new activities and viewing all the existing activities.

@sleidig sleidig self-assigned this Mar 14, 2021
@sleidig sleidig changed the title Improvements to new activity & event system Allow activities to be added from school details view Jul 5, 2021
@sleidig sleidig added Priority: High Status: Community Help Wanted (good first issue) simple tasks that don't require understanding every last detail of our platform labels Aug 2, 2021
@sleidig sleidig removed their assignment Aug 2, 2021
@TheSlimvReal
Copy link
Collaborator

  • Load all RecrringActivities with the EntityMapperService
  • Display the RecurringActivities in a input with autocomplete
  • Add a button Add school to activity
  • Clicking button should add the ID of the school to the linkedGroups array of the RecrurringActivity that is selected in the input field and save it with the entity mapper

@kirtijadhav kirtijadhav removed their assignment Sep 22, 2021
@sleidig sleidig moved this to Triage in All Tasks & Issues Feb 8, 2022
@sleidig sleidig moved this from Triage to Todo in All Tasks & Issues Feb 8, 2022
@sleidig sleidig removed the Status: Community Help Wanted (good first issue) simple tasks that don't require understanding every last detail of our platform label Mar 18, 2022
@christophscheuing christophscheuing self-assigned this Jun 2, 2022
@christophscheuing christophscheuing moved this from Todo to In Progress in All Tasks & Issues Jun 9, 2022
@sleidig
Copy link
Member Author

sleidig commented Jul 5, 2022

additional thoughts after trying the first implementation:

  • add attendance details to the same / another panel of school details also (like in child details, option to see a detailed analysis)
  • make it possible to navigate to the "Recurring Activity" details view from that list? (not sure yet how to design the UX for this, however)

sleidig added a commit that referenced this issue Jul 5, 2022
… view (#1314)

see #713 

Co-authored-by: Simon <therealslimv@yahoo.de>
Co-authored-by: Sebastian <sebastian.leidig@gmail.com>
@christophscheuing christophscheuing moved this from In Progress to In Review in All Tasks & Issues Sep 1, 2022
Repository owner moved this from In Review to Done in All Tasks & Issues Sep 29, 2022
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.11.3-master.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

5 participants