Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events created from RecurringActivity should omit deleted participants #931

Closed
sleidig opened this issue Aug 2, 2021 · 2 comments · Fixed by #1069
Closed

Events created from RecurringActivity should omit deleted participants #931

sleidig opened this issue Aug 2, 2021 · 2 comments · Fixed by #1069
Labels
Status: Community Help Wanted (good first issue) simple tasks that don't require understanding every last detail of our platform Type: Bug

Comments

@sleidig
Copy link
Member

sleidig commented Aug 2, 2021

Describe the bug
If a child is deleted but still linked to a RecurringActivity, we do skip that participant during the one-by-one roll call but it is still added to the resulting event and then shown in the participant list of the note/event details without a name:
image

To Reproduce
Steps to reproduce the behavior:

  1. Find or create a "Recurring Activity" and choose one of the linked participants
  2. Go to the Child Details of that participant and delete it
  3. "Record Attendance" (here the deleted participant will not show)
  4. Open the Details View of the resulting Event Note (e.g. through "Notes" list with "include events" toggle active)
  5. Here the delete participant still shows up as a nameless line

Expected behavior
The Event should not at all be linked with deleted records, only existing participants of the RecuringActivity should be linked to new Event entities.
@sleidig sleidig added Type: Bug Status: Community Help Wanted (good first issue) simple tasks that don't require understanding every last detail of our platform labels Aug 2, 2021
@sleidig sleidig mentioned this issue Aug 2, 2021
Closed
@kirtijadhav kirtijadhav removed their assignment Sep 22, 2021
sleidig added a commit that referenced this issue Dec 17, 2021
@sleidig
fix(*): remove links to deleted participants from events
d2e2602 
ideally this should be done in the attendance-service but that would require loading all child entities there additionally.

fixes #931
@sleidig sleidig mentioned this issue Dec 17, 2021
Merged
sleidig added a commit that referenced this issue Dec 17, 2021
@sleidig
fix(*): remove links to deleted participants from events
2f0b035 
ideally this should be done in the attendance-service but that would require loading all child entities there additionally.

fixes #931
sleidig added a commit that referenced this issue Dec 18, 2021
@sleidig
fix(*): remove links to deleted participants from events
596dda8 
ideally this should be done in the attendance-service but that would require loading all child entities there additionally.

fixes #931
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 2.59.0-master.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 2.59.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Community Help Wanted (good first issue) simple tasks that don't require understanding every last detail of our platform Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sort roll call participants Aam-Digital/ndb-core
3 participants
@sleidig @aam-digital-ci @kirtijadhav