Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #753 'Search broken for imported data'. #1044

Merged
merged 6 commits into from
Dec 17, 2021
Merged

fixes #753 'Search broken for imported data'. #1044

merged 6 commits into from
Dec 17, 2021

Conversation

Paschild
Copy link
Contributor

@Paschild Paschild commented Dec 1, 2021

see issue: #753

guess its more like a work around for now but looking forward to your opinions

@github-actions
Copy link

github-actions bot commented Dec 1, 2021

Deployed to https://test-deployment-pr-1044.herokuapp.com/

TheSlimvReal
TheSlimvReal reviewed Dec 7, 2021
View reviewed changes
Copy link
Collaborator

@TheSlimvReal TheSlimvReal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This is exactly what I had in mind and it works perfectly!
I merged the latest master into the branch.

It would be great if you could add a test, but then this is ready to be merged. Maybe the code could even become more easy once this is combined with the other changes to the import component

sleidig
sleidig approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Great 👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sleidig sleidig merged commit 8a7ca31 into master Dec 17, 2021
@sleidig sleidig deleted the hwr/data-import/search-broken-for-imported-data branch December 17, 2021 17:56
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 2.59.0-master.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

sleidig added a commit that referenced this pull request Dec 17, 2021
@Paschild @TheSlimvReal @sleidig
fix(import): correctly create search index for imported data (#1044)
70f210e 
fixes #753

Co-authored-by: Simon <therealslimv@yahoo.de>
Co-authored-by: Sebastian Leidig <sebastian.leidig@gmail.com>
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 2.59.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@sleidig sleidig mentioned this pull request Jul 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSlimvReal TheSlimvReal TheSlimvReal left review comments

@sleidig sleidig sleidig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Paschild @aam-digital-ci @sleidig @TheSlimvReal