Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable validators #1080

Merged
merged 37 commits into from
Jan 19, 2022
Merged

Configurable validators #1080

merged 37 commits into from
Jan 19, 2022

Conversation

Schottkyc137
Copy link
Contributor

see issue: #1057

Visible/Frontend Changes

None

Architectural/Backend Changes

  • Validation rules can be defined via the config or an entity-field's schema

@github-actions
Copy link

@Schottkyc137 Schottkyc137 marked this pull request as ready for review January 11, 2022 19:50
Copy link
Collaborator

@TheSlimvReal TheSlimvReal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, there is also a problem with the number inputs.
When selecting type="number" no validation for the input is possible and any letters are omitted when saving. When selecting type="string" the up and down buttons are missing but it is possible to display a error message in case a invalid character has been written.

@@ -1,12 +1,12 @@
<mat-form-field [formGroup]="formControl.parent">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be changed everywhere?

src/app/core/keys-pipe/keys.pipe.spec.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TheSlimvReal TheSlimvReal merged commit e907419 into master Jan 19, 2022
@TheSlimvReal TheSlimvReal deleted the 1057-configurable-validators branch January 19, 2022 08:41
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 2.60.0-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 2.60.0-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants