-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable validators #1080
Configurable validators #1080
Conversation
Deployed to https://test-deployment-pr-1080.herokuapp.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, there is also a problem with the number inputs.
When selecting type="number"
no validation for the input is possible and any letters are omitted when saving. When selecting type="string"
the up and down buttons are missing but it is possible to display a error message in case a invalid character has been written.
@@ -1,12 +1,12 @@ | |||
<mat-form-field [formGroup]="formControl.parent"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be changed everywhere?
...mponents/entity-utils/dynamic-form-components/edit-percentage/edit-percentage.component.html
Show resolved
Hide resolved
Co-authored-by: Simon <33730997+TheSlimvReal@users.noreply.github.com>
…to 1057-configurable-validators
…to 1057-configurable-validators
…alidators # Conflicts: # src/app/core/entity-components/entity-form/entity-form/FormConfig.ts # src/locale/messages.de.xlf # src/locale/messages.fr.xlf # src/locale/messages.xlf
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
🎉 This PR is included in version 2.60.0-master.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.60.0-master.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
see issue: #1057
Visible/Frontend Changes
None
Architectural/Backend Changes