Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit entity label fix #1226

Merged
merged 5 commits into from
Apr 26, 2022
Merged

Edit entity label fix #1226

merged 5 commits into from
Apr 26, 2022

Conversation

TheSlimvReal
Copy link
Collaborator

Currently there is a bad UX when editing a single entity:
image

This is due to the label being linked to the wrong input element.

Visible/Frontend Changes

  • Input element and label behave correctly

Architectural/Backend Changes

--

@github-actions
Copy link
Contributor

Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like there still is something off (School History in Child Details):
image

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sleidig sleidig merged commit 288a95f into master Apr 26, 2022
@sleidig sleidig deleted the edit-entity-label-fix branch April 26, 2022 08:01
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.4.0-master.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants