fix(*): Improved layout of note details in mobile view #1290
Conversation
|
Deployed to https://test-deployment-pr-1290.herokuapp.com/ |
| * Flex | ||
| */ | ||
|
|
||
| .flex-grow { |
There was a problem hiding this comment.
isn't this something FlexLayoutModule can provide?
@Schottkyc137, wanna keep an eye on this while refactoring and cleaning up the styles?
There was a problem hiding this comment.
I actually do believe that this is a better way of doing things (I am using a similar approach while refactoring). I actually think that we should get rid of FxFlex altogether. We will probably have a discussion about this topic when I'm ready for review but the basic reasoning is that CSS flex classes are in most cases (all that I have encountered in the app) just as potent and – at least from my point of view – more clear than fxFlex. The latter works using "magic" by using styles that are added dynamically via scripts. This is almost never needed.
# Conflicts: # src/app/child-dev-project/notes/note-details/child-meeting-attendance/child-meeting-note-attendance.component.html
There was a problem hiding this comment.
The layout still looks unclean as the participant names expand to various widths based on the length of name:
On mobile it would be good to get the colored dot on the same line as the status dropdown and align the trash icon with something - maybe forced on a line with remarks?
|
SonarCloud Quality Gate failed.
|
|
🎉 This PR is included in version 3.7.3-master.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
see issue: #1274
Visible/Frontend Changes
Architectural/Backend Changes
--