Add option to memorize Tab state in the browser URL #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://test-deployment-pr-1293.herokuapp.com/ |
| MatTabGroupHarness | ||
| ); | ||
| const activatedRoute = TestBed.inject(ActivatedRoute); | ||
| await tabGroupHarness.selectTab({ label: "D" }); |
There was a problem hiding this comment.
Pretty clean test! I have never used this TestbedHarnessEnvironment before
# Conflicts: # src/app/core/entity-components/entity-details/entity-details.component.html # src/app/core/entity-components/entity-details/entity-details.module.ts # src/app/core/entity-components/entity-list/entity-list.component.html
|
Kudos, SonarCloud Quality Gate passed!
|
TheSlimvReal
approved these changes
Jun 16, 2022
|
🎉 This PR is included in version 3.6.2-master.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.6.3-master.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue: #1254
Visible/Frontend Changes
The proposed solution is based on a directive that can be applied to
mat-tab-groupslike so:No further setup is required