Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typings for jsonQuery and md5 #1298

Merged
merged 2 commits into from
Jun 5, 2022
Merged

Add typings for jsonQuery and md5 #1298

merged 2 commits into from
Jun 5, 2022

Conversation

Schottkyc137
Copy link
Contributor

We have two dependencies that are not typed, i.e. had to be imported using the const x = require("x") style. Typing definitions exist for both of these dependencies that were added

Architectural/Backend Changes

  • Added typings for md5
  • Added typings for jsonQuery

@github-actions
Copy link

Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. Thanks for raising our level on code quality! :-)

@sonarcloud
Copy link

sonarcloud bot commented Jun 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sleidig sleidig merged commit ddc82a0 into master Jun 5, 2022
@sleidig sleidig deleted the typings branch June 5, 2022 07:50
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.6.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.6.2-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants