[WIP] school detail and school list feature #156
Conversation
# Conflicts: # src/app/app.routing.ts
codingfabi
changed the title
SuppenGeist
changed the title
Lorsbyjm
changed the title
# Conflicts: # npm-shrinkwrap.json # src/app/app.routing.ts # src/app/children/children-list/children-list.component.ts # src/app/schools/school-detail/school-detail.component.html # src/app/schools/school-detail/school-detail.component.ts # src/app/schools/schools-list/schools-list.component.css # src/app/schools/schools-list/schools-list.component.html # src/app/schools/schools-list/schools-list.component.ts # src/app/schools/schoolsShared/school.ts # src/app/schools/schoolsShared/schools.services.ts
# Conflicts: # src/app/schools/school-detail/school-detail.component.html
…tching students that are visiting this school.
…el where each student saves the school it attends
… class of an entity around. Replaces the construct { new(id: string): T; }
# Conflicts: # src/app/schools/school-detail/school-detail.component.html # src/app/schools/schools-list/schools-list.component.html
|
What's the status on this? Is this anywhere near completion? |
|
I think it is almost completed... I hope we can finish it tomorrow, so stay tuned. |
|
Please also look at sentry. There was an error raised in your files |
The SchoolDetail screen is finished, but now I also wanted to bring the new ChildSchoolRelations into play. This takes me a little bit more time but I think it would be nice to finally have this implemented. |
| @@ -0,0 +1,7 @@ | |||
| import {Entity} from './entity'; | |||
|
|
|||
| export abstract class EntityRelation extends Entity { | |||
There was a problem hiding this comment.
In which way is EntityRelation different from Entity? Does it really require a separate class for this?
| import {Observable} from '../../../../node_modules/rxjs/Rx'; | ||
|
|
||
| @Injectable() | ||
| export class SchoolsServices { |
There was a problem hiding this comment.
Naming convention is to use "service" in singular (i.e. file name "schools.service.ts", class name "SchoolsService")
|
I do understand why this is taking long - quite a complex challenge with the relationship modelling between Have you looked into solutions that keep the relationship loading out of the entity classes (i.e. move/remove |
see #42
Implement the school details view