File upload fixes #1562
Merged
File upload fixes #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://pr-1562.aam-digital.net/ |
TheSlimvReal
force-pushed
the
file-upload-fixes
branch
from
5aed56d to
700d221
Compare
|
Has been deployed to |
# Conflicts: # src/app/core/entity-components/entity-form/entity-form/entity-form.component.ts
sleidig
requested changes
Dec 1, 2022
|
@sleidig sorry, I forgot to update the deployment after merging the master. The issues you mentioned seem to have been fixed after merging the latest changes from the master. I couldn't reproduce them afterwards. |
|
SonarCloud Quality Gate failed.
|
sleidig
approved these changes
Dec 2, 2022
|
🎉 This PR is included in version 3.14.0-master.22 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file upload has been restructured to be more in-line with other form components and to support the automatic form-update functionality.
Visible/Frontend Changes
Architectural/Backend Changes
PUT-Requests to CouchDB are executed in sequence in order to support uploading of multiple files at the same timeEntityFormComponenthas been cleaned up to less often create new forms. Now it only creates the form one and then updates the values when needed.